From: Kees Cook <kees@kernel.org>
To: nicolas.bouchinet@clip-os.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Luis Chamberlain <mcgrof@kernel.org>,
Joel Granados <j.granados@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
Neil Horman <nhorman@tuxdriver.com>, Lin Feng <linf@wangsu.com>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH v4 1/2] coredump: Fixes core_pipe_limit sysctl proc_handler
Date: Wed, 15 Jan 2025 16:32:18 -0800 [thread overview]
Message-ID: <202501151630.87A0A8E7C4@keescook> (raw)
In-Reply-To: <20250115132211.25400-2-nicolas.bouchinet@clip-os.org>
On Wed, Jan 15, 2025 at 02:22:08PM +0100, nicolas.bouchinet@clip-os.org wrote:
> Any negative write or >= to INT_MAX in core_pipe_limit sysctl would
> hypothetically allow a user to create very high load on the system by
> running processes that produces a coredump in case the core_pattern
> sysctl is configured to pipe core files to user space helper.
> Memory or PID exhaustion should happen before but it anyway breaks the
> core_pipe_limit semantic.
Isn't this true for "0" too (the default)? I'm not opposed to the change
since it makes things more clear, but I don't think the >=INT_MAX
problem is anything more than "functionally identical to 0". :)
Reviewed-by: Kees Cook <kees@kernel.org>
--
Kees Cook
next prev parent reply other threads:[~2025-01-16 0:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 13:22 [PATCH v4 0/2] Fixes multiple sysctl proc_handler usage error nicolas.bouchinet
2025-01-15 13:22 ` [PATCH v4 1/2] coredump: Fixes core_pipe_limit sysctl proc_handler nicolas.bouchinet
2025-01-16 0:32 ` Kees Cook [this message]
2025-01-17 10:55 ` Nicolas Bouchinet
2025-01-15 13:22 ` [PATCH v4 2/2] sysctl: Fix underflow value setting risk in vm_table nicolas.bouchinet
2025-01-16 0:32 ` Kees Cook
2025-02-17 10:35 ` [PATCH v4 0/2] Fixes multiple sysctl proc_handler usage error Joel Granados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202501151630.87A0A8E7C4@keescook \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=j.granados@samsung.com \
--cc=jack@suse.cz \
--cc=jirislaby@kernel.org \
--cc=linf@wangsu.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nicolas.bouchinet@clip-os.org \
--cc=nicolas.bouchinet@ssi.gouv.fr \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.