From: Jakub Kicinski <kuba@kernel.org>
To: Gui-Dong Han <2045gemini@gmail.com>
Cc: 3chas3@gmail.com, linux-atm-general@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
baijiaju1990@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH] atm/fore200e: Fix possible data race in fore200e_open()
Date: Thu, 16 Jan 2025 16:59:14 -0800 [thread overview]
Message-ID: <20250116165914.35f72b1a@kernel.org> (raw)
In-Reply-To: <20250115131006.364530-1-2045gemini@gmail.com>
On Wed, 15 Jan 2025 13:10:06 +0000 Gui-Dong Han wrote:
> Protect access to fore200e->available_cell_rate with rate_mtx lock to
> prevent potential data race.
>
> The field fore200e.available_cell_rate is generally protected by the lock
> fore200e.rate_mtx when accessed. In all other read and write cases, this
> field is consistently protected by the lock, except for this case and
> during initialization.
That's not sufficient in terms of analysis.
You need to be able to articulate what can go wrong.
--
pw-bot: reject
next prev parent reply other threads:[~2025-01-17 0:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 13:10 [PATCH] atm/fore200e: Fix possible data race in fore200e_open() Gui-Dong Han
2025-01-17 0:59 ` Jakub Kicinski [this message]
2025-01-17 2:28 ` Gui-Dong Han
2025-01-20 10:55 ` Simon Horman
2025-01-22 2:48 ` Gui-Dong Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116165914.35f72b1a@kernel.org \
--to=kuba@kernel.org \
--cc=2045gemini@gmail.com \
--cc=3chas3@gmail.com \
--cc=baijiaju1990@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.