From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
kernel-team@meta.com, max@kutsevol.com, thepacketgeek@gmail.com
Subject: Re: [PATCH net-next v2 3/5] netconsole: add support for sysdata and CPU population
Date: Thu, 16 Jan 2025 17:44:05 -0800 [thread overview]
Message-ID: <20250116174405.20a0e20b@kernel.org> (raw)
In-Reply-To: <20250115-netcon_cpu-v2-3-95971b44dc56@debian.org>
On Wed, 15 Jan 2025 05:35:20 -0800 Breno Leitao wrote:
> + WARN_ON_ONCE(userdata_len + sysdata_len >
> + MAX_EXTRADATA_ENTRY_LEN * MAX_EXTRADATA_ITEMS);
> +
> + /* nt->sysdata_length will be used later to decide if the message
> + * needs to be fragmented.
> + * userdata_len cannot be used for it, once next sysdata append should
> + * start from the same userdata_len location, and only overwrite old
> + * sysdata.
> + */
> + nt->sysdata_length = sysdata_len;
Updating nt-> fields at runtime is something we haven't done before,
right? What's the locking? We depend on target_list_lock ?
Looks like previously all the data was on the stack, now we have a mix.
Maybe we can pack all the bits of state into a struct for easier
passing around, but still put it on the stack?
next prev parent reply other threads:[~2025-01-17 1:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 13:35 [PATCH net-next v2 0/5] netconsole: Add support for CPU population Breno Leitao
2025-01-15 13:35 ` [PATCH net-next v2 1/5] netconsole: Rename userdata to extradata Breno Leitao
2025-01-15 13:35 ` [PATCH net-next v2 2/5] netconsole: Helper to count number of used entries Breno Leitao
2025-01-15 13:35 ` [PATCH net-next v2 3/5] netconsole: add support for sysdata and CPU population Breno Leitao
2025-01-17 1:44 ` Jakub Kicinski [this message]
2025-01-17 11:02 ` Breno Leitao
2025-01-18 2:35 ` Jakub Kicinski
2025-01-20 17:30 ` Breno Leitao
2025-01-20 19:06 ` Jakub Kicinski
2025-01-24 15:28 ` Breno Leitao
2025-01-15 13:35 ` [PATCH net-next v2 4/5] netconsole: selftest: test for sysdata CPU Breno Leitao
2025-01-15 13:35 ` [PATCH net-next v2 5/5] netconsole: docs: Add documentation for CPU number auto-population Breno Leitao
2025-01-15 22:56 ` Randy Dunlap
2025-01-16 9:31 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116174405.20a0e20b@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=max@kutsevol.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=thepacketgeek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.