From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ v1] shared/shell: Always set stdout to be line buffered
Date: Thu, 16 Jan 2025 15:39:00 -0500 [thread overview]
Message-ID: <20250116203900.3722253-1-luiz.dentz@gmail.com> (raw)
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This always set stdout to be line buffered to avoid cluttering the
output:
https://github.com/bluez/bluez/issues/747#issuecomment-2596840382
---
src/shared/shell.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/shared/shell.c b/src/shared/shell.c
index aa6c16c8c430..37c747f8fa23 100644
--- a/src/shared/shell.c
+++ b/src/shared/shell.c
@@ -1268,7 +1268,6 @@ static void rl_init(void)
/* Allow conditional parsing of the ~/.inputrc file. */
rl_readline_name = data.name;
- setlinebuf(stdout);
rl_attempted_completion_function = shell_completion;
rl_erase_empty_line = 1;
@@ -1405,6 +1404,8 @@ done:
mainloop_init();
+ /* Always set stdout as line buffered */
+ setlinebuf(stdout);
rl_init();
data.init = true;
--
2.47.1
next reply other threads:[~2025-01-16 20:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 20:39 Luiz Augusto von Dentz [this message]
2025-01-16 22:10 ` [BlueZ,v1] shared/shell: Always set stdout to be line buffered bluez.test.bot
2025-01-17 18:10 ` [PATCH BlueZ v1] " patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116203900.3722253-1-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.