From: Zorro Lang <zlang@kernel.org>
To: fstests@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: [PATCH] fstests: workaround for gcc-15
Date: Fri, 17 Jan 2025 12:37:09 +0800 [thread overview]
Message-ID: <20250117043709.2941857-1-zlang@kernel.org> (raw)
GCC-15 does a big change, it changes the default language version for
C compilation from -std=gnu17 to -std=gnu23. That cause lots of "old
style" C codes hit build errors. On the other word, current xfstests
can't be used with GCC-15. So -std=gnu17 can help that.
Signed-off-by: Zorro Lang <zlang@kernel.org>
---
Hi,
I send this patch just for talking about this issue. The upcoming gcc-15
does lots of changes, a big change is using C23 by default:
https://gcc.gnu.org/gcc-15/porting_to.html
xfstests has many old style C codes, they hard to be built with gcc-15.
So we have to either add -std=$old_version (likes this patch), or port
the code to C23.
This patch is just a workaround (and a reminder for someone might hit
this issue with gcc-15 too). If you have any good suggestions or experience
(for this kind of issue) to share, feel free to reply.
Thanks,
Zorro
include/builddefs.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/builddefs.in b/include/builddefs.in
index 5b5864278..ef124bb87 100644
--- a/include/builddefs.in
+++ b/include/builddefs.in
@@ -75,7 +75,7 @@ HAVE_RLIMIT_NOFILE = @have_rlimit_nofile@
NEED_INTERNAL_XFS_IOC_EXCHANGE_RANGE = @need_internal_xfs_ioc_exchange_range@
HAVE_FICLONE = @have_ficlone@
-GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall
+GCCFLAGS = -funsigned-char -fno-strict-aliasing -std=gnu17 -Wall
SANITIZER_CFLAGS += @autovar_init_cflags@
ifeq ($(PKG_PLATFORM),linux)
--
2.47.1
next reply other threads:[~2025-01-17 4:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 4:37 Zorro Lang [this message]
2025-01-17 17:27 ` [PATCH] fstests: workaround for gcc-15 Darrick J. Wong
2025-01-18 14:32 ` Zorro Lang
2025-01-18 20:14 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250117043709.2941857-1-zlang@kernel.org \
--to=zlang@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.