Re: [PATCH 00/21] hw/i386/pc: Remove deprecated 2.4 and 2.5 PC machines

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Jan 16, 2025 at 12:22:26AM +0100, Philippe Mathieu-Daudé wrote:
> The versioned 'pc' and 'q35' machines up to 2.12 been marked
> as deprecated two releases ago, and are older than 6 years,
> so according to our support policy we can remove them.
> 
> This series only includes the 2.4 and 2.5 machines removal,
> as it is a big enough number of LoC removed. Rest will
> follow. Highlight is the legacy fw_cfg API removal :)

tagged, thanks!

> Philippe Mathieu-Daudé (21):
>   hw/i386/pc: Remove unused pc_compat_2_3 declarations
>   hw/i386/pc: Remove deprecated pc-q35-2.4 and pc-i440fx-2.4 machines
>   hw/i386/pc: Remove PCMachineClass::broken_reserved_end field
>   hw/i386/pc: Remove pc_compat_2_4[] array
>   target/i386/cpu: Remove X86CPU::check_cpuid field
>   target/i386/cpu: Pass Error** to x86_cpu_filter_features()
>   hw/core/machine: Remove hw_compat_2_4[] array
>   hw/net/e1000: Remove unused E1000_FLAG_MAC flag
>   hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_MIGRATE_EXTRA definition
>   hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_DISABLE_PCIE definition
>   hw/i386/pc: Remove deprecated pc-q35-2.5 and pc-i440fx-2.5 machines
>   hw/i386/x86: Remove X86MachineClass::save_tsc_khz field
>   hw/nvram/fw_cfg: Remove legacy FW_CFG_ORDER_OVERRIDE
>   hw/core/machine: Remove hw_compat_2_5[] array
>   hw/block/fdc-isa: Remove 'fallback' property
>   hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_OLD_PCI_CONFIGURATION
>     definition
>   hw/scsi/vmw_pvscsi: Remove PVSCSI_COMPAT_DISABLE_PCIE_BIT definition
>   hw/scsi/vmw_pvscsi: Convert DeviceRealize -> InstanceInit
>   hw/net/vmxnet3: Remove VMXNET3_COMPAT_FLAG_OLD_MSI_OFFSETS definition
>   hw/net/vmxnet3: Remove VMXNET3_COMPAT_FLAG_DISABLE_PCIE definition
>   hw/net/vmxnet3: Merge DeviceRealize in InstanceInit
> 
>  docs/about/removed-features.rst |   4 ++
>  include/hw/boards.h             |   9 +--
>  include/hw/i386/pc.h            |  10 ---
>  include/hw/i386/x86.h           |   5 --
>  include/hw/loader.h             |   2 -
>  include/hw/nvram/fw_cfg.h       |  10 ---
>  include/hw/virtio/virtio-pci.h  |   8 ---
>  target/i386/cpu.h               |   1 -
>  hw/block/fdc-isa.c              |   4 +-
>  hw/core/loader.c                |  14 ----
>  hw/core/machine.c               |  18 ------
>  hw/i386/pc.c                    |  42 ++----------
>  hw/i386/pc_piix.c               |  26 --------
>  hw/i386/pc_q35.c                |  26 --------
>  hw/i386/x86.c                   |   1 -
>  hw/net/e1000.c                  |  63 ++++--------------
>  hw/net/vmxnet3.c                |  44 ++-----------
>  hw/nvram/fw_cfg.c               | 109 ++------------------------------
>  hw/scsi/vmw_pvscsi.c            |  67 ++++----------------
>  hw/virtio/virtio-pci.c          |  15 +----
>  system/vl.c                     |   5 --
>  target/i386/cpu.c               |  27 +++-----
>  target/i386/machine.c           |   5 +-
>  23 files changed, 61 insertions(+), 454 deletions(-)
> 
> -- 
> 2.47.1