From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Fabiano Rosas <farosas@suse.de>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
devel@lists.libvirt.org,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Kashyap Chamarthy" <kchamart@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>
Subject: [PATCH 3/3] tests/qtest/test-x86-cpuid-compat: Replaced the removed pc-i440fx-2.* machines
Date: Fri, 17 Jan 2025 11:27:38 +0100 [thread overview]
Message-ID: <20250117102738.59714-4-thuth@redhat.com> (raw)
In-Reply-To: <20250117102738.59714-1-thuth@redhat.com>
Since the pc-i440fx-2.* machine types have been removed, let's run
the tests with the corresponding q35 machine types instead (until
those get removed, too, then we have to remove the tests completely).
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/test-x86-cpuid-compat.c | 34 ++++++++++++++---------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/tests/qtest/test-x86-cpuid-compat.c b/tests/qtest/test-x86-cpuid-compat.c
index 9cbc8b7ae9..f77e481279 100644
--- a/tests/qtest/test-x86-cpuid-compat.c
+++ b/tests/qtest/test-x86-cpuid-compat.c
@@ -346,23 +346,23 @@ int main(int argc, char **argv)
/* Check compatibility of old machine-types that didn't
* auto-increase level/xlevel/xlevel2: */
- if (qtest_has_machine("pc-i440fx-2.7")) {
- add_cpuid_test("x86/cpuid/auto-level/pc-2.7",
+ if (qtest_has_machine("pc-q35-2.7")) {
+ add_cpuid_test("x86/cpuid/auto-level/pc-q35-2.7",
"486", "arat=on,avx512vbmi=on,xsaveopt=on",
- "pc-i440fx-2.7", "level", 1);
- add_cpuid_test("x86/cpuid/auto-xlevel/pc-2.7",
+ "pc-q35-2.7", "level", 1);
+ add_cpuid_test("x86/cpuid/auto-xlevel/pc-q35-2.7",
"486", "3dnow=on,sse4a=on,invtsc=on,npt=on,svm=on",
- "pc-i440fx-2.7", "xlevel", 0);
- add_cpuid_test("x86/cpuid/auto-xlevel2/pc-2.7",
- "486", "xstore=on", "pc-i440fx-2.7",
+ "pc-q35-2.7", "xlevel", 0);
+ add_cpuid_test("x86/cpuid/auto-xlevel2/pc-q35-2.7",
+ "486", "xstore=on", "pc-q35-2.7",
"xlevel2", 0);
}
- if (qtest_has_machine("pc-i440fx-2.9")) {
- add_cpuid_test("x86/cpuid/auto-level7/pc-i440fx-2.9/off",
- "Conroe", NULL, "pc-i440fx-2.9",
+ if (qtest_has_machine("pc-q35-2.9")) {
+ add_cpuid_test("x86/cpuid/auto-level7/pc-q35-2.9/off",
+ "Conroe", NULL, "pc-q35-2.9",
"level", 10);
- add_cpuid_test("x86/cpuid/auto-level7/pc-i440fx-2.9/on",
- "Conroe", "erms=on", "pc-i440fx-2.9",
+ add_cpuid_test("x86/cpuid/auto-level7/pc-q35-2.9/on",
+ "Conroe", "erms=on", "pc-q35-2.9",
"level", 10);
}
@@ -371,12 +371,12 @@ int main(int argc, char **argv)
* code on old machine-types. Just check that the compat code
* is working correctly:
*/
- if (qtest_has_machine("pc-i440fx-2.4")) {
- add_cpuid_test("x86/cpuid/xlevel-compat/pc-i440fx-2.4/npt-off",
- "SandyBridge", NULL, "pc-i440fx-2.4",
+ if (qtest_has_machine("pc-q35-2.4")) {
+ add_cpuid_test("x86/cpuid/xlevel-compat/pc-q35-2.4/npt-off",
+ "SandyBridge", NULL, "pc-q35-2.4",
"xlevel", 0x80000008);
- add_cpuid_test("x86/cpuid/xlevel-compat/pc-i440fx-2.4/npt-on",
- "SandyBridge", "svm=on,npt=on", "pc-i440fx-2.4",
+ add_cpuid_test("x86/cpuid/xlevel-compat/pc-q35-2.4/npt-on",
+ "SandyBridge", "svm=on,npt=on", "pc-q35-2.4",
"xlevel", 0x80000008);
}
--
2.47.1
next prev parent reply other threads:[~2025-01-17 10:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 10:27 [PATCH 0/3] Remove deprecated machines pc-i440fx-2.4 up to pc-i440fx-2.12 Thomas Huth
2025-01-17 10:27 ` [PATCH 1/3] tests/qtest/test-x86-cpuid-compat: Remove tests related to pc-i440fx-2.3 Thomas Huth
2025-01-17 12:12 ` Fabiano Rosas
2025-01-17 16:48 ` Philippe Mathieu-Daudé
2025-01-17 10:27 ` [PATCH 2/3] hw/i386/pc_piix: Remove pc-i440fx-2.4 up to pc-i440fx-2.12 Thomas Huth
2025-01-17 11:58 ` Kashyap Chamarthy
2025-01-17 16:52 ` Philippe Mathieu-Daudé
2025-01-17 10:27 ` Thomas Huth [this message]
2025-01-17 11:07 ` [PATCH 0/3] Remove deprecated machines " Daniel P. Berrangé
2025-01-17 11:14 ` Thomas Huth
2025-01-17 11:25 ` Daniel P. Berrangé
2025-01-17 16:52 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250117102738.59714-4-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=devel@lists.libvirt.org \
--cc=farosas@suse.de \
--cc=kchamart@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.