From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
eric.dumazet@gmail.com,
syzbot+85ff1051228a04613a32@syzkaller.appspotmail.com
Subject: Re: [PATCH net-next] net: destroy dev->lock later in free_netdev()
Date: Fri, 17 Jan 2025 15:00:38 -0800 [thread overview]
Message-ID: <20250117150038.1f009a20@kernel.org> (raw)
In-Reply-To: <20250117224626.1427577-1-edumazet@google.com>
On Fri, 17 Jan 2025 22:46:26 +0000 Eric Dumazet wrote:
> syzbot complained that free_netdev() was calling netif_napi_del()
> after dev->lock mutex has been destroyed.
>
> This fires a warning for CONFIG_DEBUG_MUTEXES=y builds.
>
> Move mutex_destroy(&dev->lock) near the end of free_netdev().
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
next prev parent reply other threads:[~2025-01-17 23:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 22:46 [PATCH net-next] net: destroy dev->lock later in free_netdev() Eric Dumazet
2025-01-17 23:00 ` Jakub Kicinski [this message]
2025-01-19 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250117150038.1f009a20@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+85ff1051228a04613a32@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.