All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH v2] test: improve resiliency of malloc autotest
Date: Fri, 17 Jan 2025 17:20:41 +0300	[thread overview]
Message-ID: <20250117172041.6bfacba7@sovereign> (raw)
In-Reply-To: <20250117135239.1980838-1-bruce.richardson@intel.com>

2025-01-17 13:52 (UTC+0000), Bruce Richardson:
> The test case "test_multi_alloc_statistics" was brittle in that it did
> some allocations and frees and then checked statistics without
> considering the initial state of the malloc heaps. This meant that,
> depending on what allocations/frees were done beforehand, the test can
> sometimes fail.
> 
> We can improve resiliency by running the test using a new malloc heap,
> which means it is unaffected by any previous allocations.
> 
> Bugzilla ID: 1579
> Fixes: a40a1f8231b4 ("app: various tests update")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2:
> * removed unnecessary extra include
> * only added new code for non-windows, since using mmap for allocation.

Why is it necessary to use `mmap()` and not portable `malloc()`?
Even the comment in the patch says "malloc" :)

  reply	other threads:[~2025-01-17 14:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-17 12:59 [PATCH] test: improve resiliency of malloc autotest Bruce Richardson
2025-01-17 13:52 ` [PATCH v2] " Bruce Richardson
2025-01-17 14:20   ` Dmitry Kozlyuk [this message]
2025-01-17 14:26     ` Bruce Richardson
2025-01-17 16:57       ` Stephen Hemminger
2025-01-17 14:40 ` [PATCH v3] " Bruce Richardson
2025-01-24  7:18   ` fengchengwen
2025-02-06 11:40     ` Bruce Richardson
2025-02-07  7:44       ` fengchengwen
2025-02-07  8:47         ` Bruce Richardson
2025-02-07 14:31 ` [PATCH] " Bruce Richardson
2025-02-07 14:32 ` [PATCH v4] " Bruce Richardson
2025-02-08  0:52   ` fengchengwen
2025-03-26 17:13 ` [PATCH v5] " Bruce Richardson
2025-06-04 16:02   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250117172041.6bfacba7@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.