From: Jakub Kicinski <kuba@kernel.org>
To: John Daley <johndale@cisco.com>
Cc: benve@cisco.com, satishkh@cisco.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
netdev@vger.kernel.org, Nelson Escobar <neescoba@cisco.com>
Subject: Re: [PATCH net-next v6 3/3] enic: Use the Page Pool API for RX
Date: Sat, 18 Jan 2025 17:24:20 -0800 [thread overview]
Message-ID: <20250118172420.48d3a914@kernel.org> (raw)
In-Reply-To: <20250117080139.28018-4-johndale@cisco.com>
On Fri, 17 Jan 2025 00:01:39 -0800 John Daley wrote:
> @@ -1752,6 +1763,11 @@ static int enic_open(struct net_device *netdev)
> }
>
> for (i = 0; i < enic->rq_count; i++) {
> + /* create a page pool for each RQ */
> + pp_params.napi = &enic->napi[i];
> + pp_params.queue_idx = i;
> + enic->rq[i].pool = page_pool_create(&pp_params);
Aren't you missing an error check here?
> /* enable rq before updating rq desc */
> vnic_rq_enable(&enic->rq[i].vrq);
> vnic_rq_fill(&enic->rq[i].vrq, enic_rq_alloc_buf);
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-19 1:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 8:01 [PATCH net-next v6 0/3] enic: Use Page Pool API for receiving packets John Daley
2025-01-17 8:01 ` [PATCH net-next v6 1/3] enic: Move RX functions to their own file John Daley
2025-01-17 8:01 ` [PATCH net-next v6 2/3] enic: Simplify RX handler function John Daley
2025-01-17 8:01 ` [PATCH net-next v6 3/3] enic: Use the Page Pool API for RX John Daley
2025-01-19 1:24 ` Jakub Kicinski [this message]
2025-01-19 19:27 ` John Daley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250118172420.48d3a914@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johndale@cisco.com \
--cc=neescoba@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=satishkh@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.