From: Jakub Kicinski <kuba@kernel.org>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Felix Fietkau <nbd@nbd.name>, Sean Wang <sean.wang@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, upstream@airoha.com
Subject: Re: [net PATCH] net: airoha: Fix wrong GDM4 register definition
Date: Sat, 18 Jan 2025 17:36:25 -0800 [thread overview]
Message-ID: <20250118173625.03d48516@kernel.org> (raw)
In-Reply-To: <20250117155257.19263-1-ansuelsmth@gmail.com>
On Fri, 17 Jan 2025 16:52:39 +0100 Christian Marangi wrote:
> diff --git a/drivers/net/ethernet/mediatek/airoha_regs.h b/drivers/net/ethernet/mediatek/airoha_regs.h
> index e448b66b5334..30c96f679735 100644
> --- a/drivers/net/ethernet/mediatek/airoha_regs.h
> +++ b/drivers/net/ethernet/mediatek/airoha_regs.h
> @@ -249,11 +249,11 @@
> #define REG_GDM3_FWD_CFG GDM3_BASE
> #define GDM3_PAD_EN_MASK BIT(28)
>
> -#define REG_GDM4_FWD_CFG (GDM4_BASE + 0x100)
> +#define REG_GDM4_FWD_CFG GDM4_BASE
> #define GDM4_PAD_EN_MASK BIT(28)
> #define GDM4_SPORT_OFFSET0_MASK GENMASK(11, 8)
>
> -#define REG_GDM4_SRC_PORT_SET (GDM4_BASE + 0x33c)
> +#define REG_GDM4_SRC_PORT_SET (GDM4_BASE + 0x23c)
> #define GDM4_SPORT_OFF2_MASK GENMASK(19, 16)
> #define GDM4_SPORT_OFF1_MASK GENMASK(15, 12)
> #define GDM4_SPORT_OFF0_MASK GENMASK(11, 8)
These are defined in drivers/net/ethernet/mediatek/airoha_eth.c
in the networking trees.
--
pw-bot: cr
prev parent reply other threads:[~2025-01-19 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 15:52 [net PATCH] net: airoha: Fix wrong GDM4 register definition Christian Marangi
2025-01-17 17:03 ` Lorenzo Bianconi
2025-01-19 1:36 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250118173625.03d48516@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
--cc=upstream@airoha.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.