From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Keerthana K <keerthana.kalyanasundaram@broadcom.com>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH v5.10-v5.15] Bluetooth: RFCOMM: Fix not validating setsockopt user input
Date: Mon, 20 Jan 2025 09:41:41 -0500 [thread overview]
Message-ID: <20250120092513-113c86aba38f5664@stable.kernel.org> (raw)
In-Reply-To: <20250120064647.3448549-1-keerthana.kalyanasundaram@broadcom.com>
[ Sasha's backport helper bot ]
Hi,
The upstream commit SHA1 provided is correct: a97de7bff13b1cc825c1b1344eaed8d6c2d3e695
WARNING: Author mismatch between patch and upstream commit:
Backport author: Keerthana K<keerthana.kalyanasundaram@broadcom.com>
Commit author: Luiz Augusto von Dentz<luiz.von.dentz@intel.com>
Status in newer kernel trees:
6.12.y | Present (exact SHA1)
6.6.y | Present (different SHA1: 4ea65e2095e9)
6.1.y | Present (different SHA1: eea40d33bf93)
5.15.y | Not found
Note: The patch differs from the upstream commit:
---
1: a97de7bff13b1 ! 1: 8599b21ee1809 Bluetooth: RFCOMM: Fix not validating setsockopt user input
@@ Metadata
## Commit message ##
Bluetooth: RFCOMM: Fix not validating setsockopt user input
+ [ Upstream commit a97de7bff13b1cc825c1b1344eaed8d6c2d3e695 ]
+
syzbot reported rfcomm_sock_setsockopt_old() is copying data without
checking user input length.
@@ Commit message
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
+ Signed-off-by: Sasha Levin <sashal@kernel.org>
+ Signed-off-by: Keerthana K <keerthana.kalyanasundaram@broadcom.com>
## net/bluetooth/rfcomm/sock.c ##
@@ net/bluetooth/rfcomm/sock.c: static int rfcomm_sock_setsockopt_old(struct socket *sock, int optname,
---
Results of testing on various branches:
| Branch | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-5.15.y | Success | Failed |
| stable/linux-5.10.y | Success | Success |
Build Errors:
Build error for stable/linux-5.15.y:
net/bluetooth/rfcomm/sock.c: In function 'rfcomm_sock_setsockopt_old':
net/bluetooth/rfcomm/sock.c:639:21: error: implicit declaration of function 'bt_copy_from_sockptr'; did you mean 'copy_from_sockptr'? [-Werror=implicit-function-declaration]
639 | if (bt_copy_from_sockptr(&opt, sizeof(opt), optval, optlen)) {
| ^~~~~~~~~~~~~~~~~~~~
| copy_from_sockptr
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:289: net/bluetooth/rfcomm/sock.o] Error 1
make[3]: Target '__build' not remade because of errors.
make[2]: *** [scripts/Makefile.build:552: net/bluetooth/rfcomm] Error 2
make[2]: Target '__build' not remade because of errors.
make[1]: *** [scripts/Makefile.build:552: net/bluetooth] Error 2
make[1]: Target '__build' not remade because of errors.
make: *** [Makefile:1906: net] Error 2
make: Target '__all' not remade because of errors.
next prev parent reply other threads:[~2025-01-20 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 6:46 [PATCH v5.10-v5.15] Bluetooth: RFCOMM: Fix not validating setsockopt user input Keerthana K
2025-01-20 7:15 ` [v5.10-v5.15] " bluez.test.bot
2025-01-20 14:41 ` Sasha Levin [this message]
2025-01-20 15:41 ` [PATCH v5.10-v5.15] " Greg KH
2025-01-24 5:43 ` Keerthana Kalyanasundaram
2025-01-24 6:13 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250120092513-113c86aba38f5664@stable.kernel.org \
--to=sashal@kernel.org \
--cc=keerthana.kalyanasundaram@broadcom.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.