Re: [PATCH v3 11/15] KVM: s390: stop using lists to keep track of used dat tables

[Steffen Eiden <seiden@linux.ibm.com>]

On Fri, Jan 17, 2025 at 08:09:34PM +0100, Claudio Imbrenda wrote:
> Until now, every dat table allocated to map a guest was put in a
> linked list. The page->lru field of struct page was used to keep track
> of which pages were being used, and when the gmap is torn down, the
> list was walked and all pages freed.
> 
> This patch gets rid of the usage of page->lru. Page tables are now
> freed by recursively walking the dat table tree.
> 
> Since s390_unlist_old_asce() becomes useless now, remove it.
> 
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

Acked-by: Steffen Eiden <seiden@linux.ibm.com>

Nit:

You missed one `ptdeѕec->pt_list` reference at

arch/s390/mm/pgalloc.c
	unsigned long *page_table_alloc(struct mm_struct *mm)
		INIT_LIST_HEAD(&ptdesc->pt_list);



Steffen