From: Nico Boehr <nrb@linux.ibm.com>
To: frankja@linux.ibm.com, imbrenda@linux.ibm.com, thuth@redhat.com
Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: [kvm-unit-tests PATCH v1] s390x: pv: fix arguments for out-of-tree-builds
Date: Mon, 20 Jan 2025 17:43:29 +0100 [thread overview]
Message-ID: <20250120164400.2261408-1-nrb@linux.ibm.com> (raw)
When building out-of-tree, the parmfile was not passed to genprotimg,
causing the selftest-setup_PV test to fail.
Fix the Makefile rule s.t. parmfile is correctly passed.
Suggested-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Signed-off-by: Nico Boehr <nrb@linux.ibm.com>
---
s390x/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/s390x/Makefile b/s390x/Makefile
index 23342bd64f44..a6cf3c144fbf 100644
--- a/s390x/Makefile
+++ b/s390x/Makefile
@@ -218,7 +218,7 @@ else
GENPROTIMG_PCF := 0x000000e0
endif
-$(patsubst %.parmfile,%.pv.bin,$(wildcard s390x/*.parmfile)): %.pv.bin: %.parmfile
+$(TEST_DIR)/selftest.pv.bin: $(SRCDIR)/s390x/selftest.parmfile
%.pv.bin: %.bin $(HOST_KEY_DOCUMENT) $(comm-key)
$(eval parmfile_args = $(if $(filter %.parmfile,$^),--parmfile $(filter %.parmfile,$^),))
$(GENPROTIMG) --host-key-document $(HOST_KEY_DOCUMENT) --no-verify $(GENPROTIMG_COMM_OPTION) $(comm-key) --x-pcf $(GENPROTIMG_PCF) $(parmfile_args) --image $(filter %.bin,$^) -o $@
--
2.47.1
next reply other threads:[~2025-01-20 16:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 16:43 Nico Boehr [this message]
2025-01-21 8:58 ` [kvm-unit-tests PATCH v1] s390x: pv: fix arguments for out-of-tree-builds Marc Hartmayer
-- strict thread matches above, loose matches on Subject: below --
2025-02-27 13:10 Nico Boehr
2025-02-27 13:15 ` Marc Hartmayer
2025-03-10 12:20 ` Janosch Frank
2025-03-10 12:38 ` Marc Hartmayer
2025-03-11 9:03 ` Nico Boehr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250120164400.2261408-1-nrb@linux.ibm.com \
--to=nrb@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.