From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] eventfd06: add AIO support check
Date: Tue, 21 Jan 2025 12:13:51 +0100 [thread overview]
Message-ID: <20250121111351.GA901075@pevik> (raw)
In-Reply-To: <CAEemH2fBVPKAJCGHvpGw9-SMW0K6JAY5E2BThwizH_oksX2MGA@mail.gmail.com>
Hi Li,
...
> > > + if (TST_RET == -ENOSYS)
> > Reviewed-by: Petr Vorel <pvorel@suse.cz>
> > Maybe to be safe to check also TST_RET?
> > if (TST_RET == -1 && TTERRNO == ENOSYS)
> I guess you mean: if (TST_RET == -1 && TST_ERR == ENOSYS).
> Typically this is correct but here it's not right. Because according
> to the io_setup(2) - Linux man page:
> "... Note also that the libaio wrapper does not follow the
> usual C library conventions for indicating errors: on
> error it returns a negated error number (the negative
> of one of the values listed in ERRORS) ... "
Ah, I'm sorry, I overlooked that.
I guess Cyril will ack this obvious fix today.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-01-21 11:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 8:22 [LTP] [PATCH] eventfd06: add AIO support check Li Wang
2025-01-21 9:26 ` Petr Vorel
2025-01-21 10:33 ` Li Wang
2025-01-21 11:13 ` Petr Vorel [this message]
2025-01-21 16:14 ` Cyril Hrubis
2025-01-22 1:50 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121111351.GA901075@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.