All of lore.kernel.org
 help / color / mirror / Atom feed
From: "“William Roche" <william.roche@oracle.com>
To: david@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com,
	pbonzini@redhat.com, philmd@linaro.org
Cc: william.roche@oracle.com
Subject: [PATCH 0/1] fallocate missing fd_offset
Date: Tue, 21 Jan 2025 17:59:55 +0000	[thread overview]
Message-ID: <20250121175956.3030149-1-william.roche@oracle.com> (raw)

From: William Roche <william.roche@oracle.com>

Working on the poisoned memory recovery mechanisms with David
Hildenbrand, it appeared that the file hole punching done with
the memory discard functions are missing the file offset value
fd_offset to correctly modify the right file location.

I'm not sure that guest_memfd would use a non zero fd_offset, but I'm
also modifying the ram_block_discard_guest_memfd_range() function to
include this fallocate use case too.

The fix is checkpatch.pl clean
make check runs fine on both ARM and x86

William Roche (1):
  system/physmem: take into account fd_offset for file fallocate

 system/physmem.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

-- 
2.43.5



             reply	other threads:[~2025-01-21 18:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 17:59 “William Roche [this message]
2025-01-21 17:59 ` [PATCH 1/1] system/physmem: take into account fd_offset for file fallocate “William Roche
2025-01-21 18:17   ` Peter Xu
2025-01-21 18:25     ` David Hildenbrand
2025-01-21 18:38       ` William Roche
2025-01-21 18:42         ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250121175956.3030149-1-william.roche@oracle.com \
    --to=william.roche@oracle.com \
    --cc=david@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.