From: Jason Gunthorpe <jgg@ziepe.ca>
To: Connor Abbott <cwabbott0@gmail.com>
Cc: Rob Clark <robdclark@gmail.com>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Sean Paul <sean@poorly.run>,
Konrad Dybcio <konradybcio@kernel.org>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Marijn Suijten <marijn.suijten@somainline.org>,
iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 3/3] drm/msm: Temporarily disable stall-on-fault after a page fault
Date: Tue, 21 Jan 2025 17:08:18 -0400 [thread overview]
Message-ID: <20250121210818.GS674319@ziepe.ca> (raw)
In-Reply-To: <20250120-msm-gpu-fault-fixes-next-v2-3-d636c4027042@gmail.com>
On Mon, Jan 20, 2025 at 10:46:47AM -0500, Connor Abbott wrote:
> To work around these problem, disable stall-on-fault as soon as we get a
> page fault until a cooldown period after pagefaults stop. This allows
> the GMU some guaranteed time to continue working. We also keep it
> disabled so long as the current devcoredump hasn't been deleted, because
> in that case we likely won't capture another one if there's a fault.
I don't have any particular interest here, but I'm surprised to read
this paragraph, maybe you could explain this some more in the commit
message?
I would think terminating transactions and returning a failure to the
GPU would be fatal to the GPU operating model when the entire point of
stall and fault handling is to make OS paging transparent to the GPU??
What happens on the GPU side when it gets this spurious failure?
Jason
next prev parent reply other threads:[~2025-01-21 21:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 15:46 [PATCH v2 0/3] iommu/arm-smmu, drm/msm: Fixes for stall-on-fault Connor Abbott
2025-01-20 15:46 ` [PATCH v2 1/3] iommu/arm-smmu: Fix spurious interrupts with stall-on-fault Connor Abbott
2025-01-22 13:52 ` Robin Murphy
2025-01-20 15:46 ` [PATCH v2 2/3] iommu/arm-smmu-qcom: Make set_stall work when the device is on Connor Abbott
2025-01-20 15:46 ` [PATCH v2 3/3] drm/msm: Temporarily disable stall-on-fault after a page fault Connor Abbott
2025-01-21 21:08 ` Jason Gunthorpe [this message]
2025-01-21 21:33 ` Connor Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121210818.GS674319@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=cwabbott0@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=freedreno@lists.freedesktop.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=sean@poorly.run \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.