All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>,
	netfilter-devel <netfilter-devel@vger.kernel.org>
Subject: Re: nft meter add behavior change post translate-to-sets change
Date: Tue, 21 Jan 2025 22:33:12 +0100	[thread overview]
Message-ID: <20250121213312.GA16069@breakpoint.cc> (raw)
In-Reply-To: <Z5APh27viio--M6o@calendula>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > ip netns del N
> > EOF
> > 
> > This is caused by:
> > b8f8ddff ("evaluate: translate meter into dynamic set")
> > 
> > Should the last rule in above example work or not?
> > If it should I will turn the above into a formal test case and will
> > work on a fix, from a quick glance it should be possible to
> > handle the collision if the existing set has matching key length.
> 
> I think it should be possible to address this case by allowing the
> meter statement to pick up an existing 'http1' set with the same key,
> this requires to extend b8f8ddff to deal with this.

I'll have a look.

  reply	other threads:[~2025-01-21 21:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 14:00 nft meter add behavior change post translate-to-sets change Florian Westphal
2025-01-21 21:20 ` Pablo Neira Ayuso
2025-01-21 21:33   ` Florian Westphal [this message]
2025-01-22  9:18     ` [PATCH nft] evaluate: allow to re-use existing metered set Florian Westphal
2025-01-28 21:06       ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250121213312.GA16069@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.