[PATCH] AF9005: fix typo in the bitmask size

[PATCH] AF9005: fix typo in the bitmask size

[Alexey V. Vissarionov]

Found by ALT Linux Team (altlinux.org) and Linux Verification Center (linuxtesting.org)

Fixes: af4e067e1dcf ("V4L/DVB (5625): Add support for the AF9005 demodulator from Afatech")

Signed-off-by: Alexey V. Vissarionov <gremlin@altlinux.org>

diff --git a/drivers/media/usb/dvb-usb/af9005-fe.c b/drivers/media/usb/dvb-usb/af9005-fe.c
index 404e56b32145f1e6..4621c1d24d578ede 100644
--- a/drivers/media/usb/dvb-usb/af9005-fe.c
+++ b/drivers/media/usb/dvb-usb/af9005-fe.c
@@ -453,7 +453,7 @@ static int af9005_fe_read_status(struct dvb_frontend *fe,
 	ret = af9005_read_register_bits(state->d,
 					xd_r_mp2if_sync_byte_locked,
 					mp2if_sync_byte_locked_pos,
-					mp2if_sync_byte_locked_pos, &temp);
+					mp2if_sync_byte_locked_len, &temp);
 	if (ret)
 		return ret;
 	if (temp)

-- 
Alexey V. Vissarionov
gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii
GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net

[PATCH] AF9005: fix typo in the bitmask size

[Alexey V. Vissarionov]

Found by ALT Linux Team (altlinux.org) and Linux Verification Center
(linuxtesting.org)

Fixes: af4e067e1dcf ("V4L/DVB (5625): Add support for the AF9005 demodulator from Afatech")

Signed-off-by: Alexey V. Vissarionov <gremlin@altlinux.org>

diff --git a/drivers/media/usb/dvb-usb/af9005-fe.c b/drivers/media/usb/dvb-usb/af9005-fe.c
index 404e56b32145f1e6..4621c1d24d578ede 100644
--- a/drivers/media/usb/dvb-usb/af9005-fe.c
+++ b/drivers/media/usb/dvb-usb/af9005-fe.c
@@ -453,7 +453,7 @@ static int af9005_fe_read_status(struct dvb_frontend *fe,
	ret = af9005_read_register_bits(state->d,
					xd_r_mp2if_sync_byte_locked,
					mp2if_sync_byte_locked_pos,
-					mp2if_sync_byte_locked_pos, &temp);
+					mp2if_sync_byte_locked_len, &temp);
	if (ret)
		return ret;
	if (temp)

-- 
Alexey V. Vissarionov
gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii
GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net

Re: [PATCH] AF9005: fix typo in the bitmask size

[Fedor Pchelkin]

Hi,

The same patch was sent twice [1,2]. Why? If something has changed, it's
good to denote the next version as v2 and briefly explain the v1->v2
changes in the zone after `---`.

[1]: https://lore.kernel.org/linux-media/20250122092733.GD12162@altlinux.org/
[2]: https://lore.kernel.org/linux-media/20250122000103.GB12162@altlinux.org/

On Wed, 22. Jan 12:27, Alexey V. Vissarionov wrote:
> Found by ALT Linux Team (altlinux.org) and Linux Verification Center
> (linuxtesting.org)

Even for the one-line fixes there should be some brief explanation on
*why* there is a problem and why it should be fixed, i.e. why there is
a typo in the code.

I guess the problem looks obvious here but still there may be some
useful information (if any) provided to the changelog.

> 
> Fixes: af4e067e1dcf ("V4L/DVB (5625): Add support for the AF9005 demodulator from Afatech")
> 

The blank line between Fixes and Signed-off-by is unwanted.

> Signed-off-by: Alexey V. Vissarionov <gremlin@altlinux.org>

git format-patch usually generates a `---` line here after the end of
the commit message.

Please take a look at [3].

[3]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format

> 
> diff --git a/drivers/media/usb/dvb-usb/af9005-fe.c b/drivers/media/usb/dvb-usb/af9005-fe.c
> index 404e56b32145f1e6..4621c1d24d578ede 100644
> --- a/drivers/media/usb/dvb-usb/af9005-fe.c
> +++ b/drivers/media/usb/dvb-usb/af9005-fe.c
> @@ -453,7 +453,7 @@ static int af9005_fe_read_status(struct dvb_frontend *fe,
> 	ret = af9005_read_register_bits(state->d,
> 					xd_r_mp2if_sync_byte_locked,
> 					mp2if_sync_byte_locked_pos,
> -					mp2if_sync_byte_locked_pos, &temp);
> +					mp2if_sync_byte_locked_len, &temp);
> 	if (ret)
> 		return ret;
> 	if (temp)
> 
> -- 
> Alexey V. Vissarionov
> gremlin ПРИ altlinux ТЧК org; +vii-cmiii-ccxxix-lxxix-xlii
> GPG: 0D92F19E1C0DC36E27F61A29CD17E2B43D879005 @ hkp://keys.gnupg.net