From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 066A4C02182 for ; Thu, 23 Jan 2025 15:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ef6Re5+WR0x+axmEpbEzOty6n+HJmJdBnBv0O1AxFns=; b=M5a+2C7794XeQe 8xOix2CCeHn1iv34LdzPUJ5KmlIoYYxedBHemrv5HLqTk1oSzhtUHAbLkj/DUFSaBMdHlbwV7cXIX PrNWcAhAabU+deLTStgGpSwcLTELJEYJ8VPuu6TiH1+6G4HvrLQS2DPIctwzPbJAJS4o+aR3//MgG iPRl6C+lYTKCTB9UAS7byuNkLMevy+jnKiTY463BjBsjxa8bJWigMOPvtmWC7JT7/Wgw9G67w7+vI /1FOPsZSans0xxKJOU7g/6XgZ+A3LuU3eophQCoGeR1vyD2nEmgfMXFiAqDqcn40L9Tm7CSL+2isx ikBpimzd7piwgYDTK/pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tazMX-0000000CjWR-2Xs5; Thu, 23 Jan 2025 15:43:21 +0000 Received: from out-176.mta1.migadu.com ([95.215.58.176]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tazMU-0000000CjW3-3czw for kvm-riscv@lists.infradead.org; Thu, 23 Jan 2025 15:43:20 +0000 Date: Thu, 23 Jan 2025 16:43:12 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1737646996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dk8ApH0cAFI0UZWZTyTEsgDS1l6elNezuUyetdqvFcU=; b=hl6Hcs/Wpq3qPazpHiKpHaE1Zxs3LexvXlU6sL69OB1v0FLTd8edx3TSReHSivNzX0HTmt TFFEJPiSREeaIeHIPaIiaNabx1gopzHVPybyZKkXyx1r8bamvo0FgP/U8QytmSi83UcrMb LVC+c6eOrY7PAWx/QKJUTfzUgtmmeoY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Alexandru Elisei Cc: eric.auger@redhat.com, lvivier@redhat.com, thuth@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, nrb@linux.ibm.com, david@redhat.com, pbonzini@redhat.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org, will@kernel.org, julien.thierry.kdev@gmail.com, maz@kernel.org, oliver.upton@linux.dev, suzuki.poulose@arm.com, yuzenghui@huawei.com, joey.gouly@arm.com, andre.przywara@arm.com Subject: Re: [kvm-unit-tests PATCH v2 14/18] run_tests: Add KVMTOOL environment variable for kvmtool binary path Message-ID: <20250123-e805b8b162fd2dfbd54b0541@orel> References: <20250120164316.31473-1-alexandru.elisei@arm.com> <20250120164316.31473-15-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250120164316.31473-15-alexandru.elisei@arm.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250123_074319_051609_E60873C1 X-CRM114-Status: GOOD ( 18.89 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org On Mon, Jan 20, 2025 at 04:43:12PM +0000, Alexandru Elisei wrote: > kvmtool is often used for prototyping new features, and a developer might > not want to install it system-wide. Add a KVMTOOL environment variable to > make it easier for tests to use a binary not in $PATH. > > Signed-off-by: Alexandru Elisei > --- > run_tests.sh | 1 + > scripts/arch-run.bash | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/run_tests.sh b/run_tests.sh > index acaaadbb879b..d38954be9093 100755 > --- a/run_tests.sh > +++ b/run_tests.sh > @@ -36,6 +36,7 @@ The following environment variables are used: > TIMEOUT Timeout duration for the timeout(1) command > CHECK Overwrites the 'check' unit test parameter (see > docs/unittests.txt) > + KVMTOOL Path to kvmtool binary for ARCH-run > EOF > } > > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > index 34f633cade01..5d840b72f8cb 100644 > --- a/scripts/arch-run.bash > +++ b/scripts/arch-run.bash > @@ -457,7 +457,7 @@ search_kvmtool_binary () > { > local kvmtoolcmd kvmtool > > - for kvmtoolcmd in lkvm vm lkvm-static; do > + for kvmtoolcmd in ${KVMTOOL:-lkvm vm lkvm-static}; do > if $kvmtoolcmd --help 2>/dev/null| grep -q 'The most commonly used'; then > kvmtool="$kvmtoolcmd" > break Let's had the help text that search_qemu_binary() has with this patch pointing out that a binary can be specified with KVMTOOL. Thanks, drew > -- > 2.47.1 > > > -- > kvm-riscv mailing list > kvm-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kvm-riscv -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7859B20C028 for ; Thu, 23 Jan 2025 15:43:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737647000; cv=none; b=JRa5uq4resR2OWx1z8ltI+sVrQ7nXY9laS2eXZ9WmBPG44gOtyY5eHlH3eFZ1Kdu39IbcVm/30WqpbDNfTMF7VafYelkkdCAHg9jyngo7WRjOVcFYZbWGOrJkt8D1OK+cUTqa33h/GBOPU729akoUXKRc/j71xwzfAHw6UaI5BI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737647000; c=relaxed/simple; bh=qkECEkGP1oaxhrwSnkqGPG21zp6cwkywDFxQbDVj3PI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PAxMD6njzRHnW5BLHnRnAIoVB3zTlTNpz2COdaYdnu7FRC8x9aGIWT1LYeIalQvztempXYRhSZXVDUO88TCVDw0q8vuAWS0a4ybxeFsEMP5ua2CesNyvtovZsomB4S8rLeVMckA0fByjM+x9iaXEHgalu8HnL3JOJMQSe19RbT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=hl6Hcs/W; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="hl6Hcs/W" Date: Thu, 23 Jan 2025 16:43:12 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1737646996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dk8ApH0cAFI0UZWZTyTEsgDS1l6elNezuUyetdqvFcU=; b=hl6Hcs/Wpq3qPazpHiKpHaE1Zxs3LexvXlU6sL69OB1v0FLTd8edx3TSReHSivNzX0HTmt TFFEJPiSREeaIeHIPaIiaNabx1gopzHVPybyZKkXyx1r8bamvo0FgP/U8QytmSi83UcrMb LVC+c6eOrY7PAWx/QKJUTfzUgtmmeoY= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Andrew Jones To: Alexandru Elisei Cc: eric.auger@redhat.com, lvivier@redhat.com, thuth@redhat.com, frankja@linux.ibm.com, imbrenda@linux.ibm.com, nrb@linux.ibm.com, david@redhat.com, pbonzini@redhat.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org, will@kernel.org, julien.thierry.kdev@gmail.com, maz@kernel.org, oliver.upton@linux.dev, suzuki.poulose@arm.com, yuzenghui@huawei.com, joey.gouly@arm.com, andre.przywara@arm.com Subject: Re: [kvm-unit-tests PATCH v2 14/18] run_tests: Add KVMTOOL environment variable for kvmtool binary path Message-ID: <20250123-e805b8b162fd2dfbd54b0541@orel> References: <20250120164316.31473-1-alexandru.elisei@arm.com> <20250120164316.31473-15-alexandru.elisei@arm.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250120164316.31473-15-alexandru.elisei@arm.com> X-Migadu-Flow: FLOW_OUT On Mon, Jan 20, 2025 at 04:43:12PM +0000, Alexandru Elisei wrote: > kvmtool is often used for prototyping new features, and a developer might > not want to install it system-wide. Add a KVMTOOL environment variable to > make it easier for tests to use a binary not in $PATH. > > Signed-off-by: Alexandru Elisei > --- > run_tests.sh | 1 + > scripts/arch-run.bash | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/run_tests.sh b/run_tests.sh > index acaaadbb879b..d38954be9093 100755 > --- a/run_tests.sh > +++ b/run_tests.sh > @@ -36,6 +36,7 @@ The following environment variables are used: > TIMEOUT Timeout duration for the timeout(1) command > CHECK Overwrites the 'check' unit test parameter (see > docs/unittests.txt) > + KVMTOOL Path to kvmtool binary for ARCH-run > EOF > } > > diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash > index 34f633cade01..5d840b72f8cb 100644 > --- a/scripts/arch-run.bash > +++ b/scripts/arch-run.bash > @@ -457,7 +457,7 @@ search_kvmtool_binary () > { > local kvmtoolcmd kvmtool > > - for kvmtoolcmd in lkvm vm lkvm-static; do > + for kvmtoolcmd in ${KVMTOOL:-lkvm vm lkvm-static}; do > if $kvmtoolcmd --help 2>/dev/null| grep -q 'The most commonly used'; then > kvmtool="$kvmtoolcmd" > break Let's had the help text that search_qemu_binary() has with this patch pointing out that a binary can be specified with KVMTOOL. Thanks, drew > -- > 2.47.1 > > > -- > kvm-riscv mailing list > kvm-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/kvm-riscv