Re: [PATCH 1/2] hw/cxl: Remove unused component_registers::io_registers[] array

[Jonathan Cameron via <qemu-devel@nongnu.org>]

On Wed, 22 Jan 2025 07:56:23 +0100
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:

> Avoid wasting 4K for each component, remove unused io_registers[].
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

These may need to come back for correctness if anyone starts
actually accessing them in the OS, but for now this is fine.
We'd have to deal with filling them with plausible values anyway
if that becomes an issue.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

I can pick these up and send on in a set to mst, or mst pick up
directly, or got through another tree. Don't mind!
> ---
>  include/hw/cxl/cxl_component.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/hw/cxl/cxl_component.h b/include/hw/cxl/cxl_component.h
> index 945ee6ffd04..ac61c3f33a5 100644
> --- a/include/hw/cxl/cxl_component.h
> +++ b/include/hw/cxl/cxl_component.h
> @@ -218,7 +218,6 @@ typedef struct component_registers {
>       *   0xe000 - 0xe3ff CXL ARB/MUX registers
>       *   0xe400 - 0xffff RSVD
>       */
> -    uint32_t io_registers[CXL2_COMPONENT_IO_REGION_SIZE >> 2];
>      MemoryRegion io;
>  
>      uint32_t cache_mem_registers[CXL2_COMPONENT_CM_REGION_SIZE >> 2];