Re: [PATCH v1 04/19] cxl: Add Get Supported Features command for kernel usage

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Wed, 22 Jan 2025 16:50:35 -0700
Dave Jiang <dave.jiang@intel.com> wrote:

> CXL spec r3.1 8.2.9.6.1 Get Supported Features (Opcode 0500h)
> The command retrieve the list of supported device-specific features
> (identified by UUID) and general information about each Feature.
> 
> The driver will retrieve the feature entries in order to make checks and
> provide information for the Get Feature and Set Feature command. One of
> the main piece of information retrieved are the effects a Set Feature
> command would have for a particular feature.
> 
> Co-developed-by: Shiju Jose <shiju.jose@huawei.com>
> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
One stray change below that either wants dropping or pushing to
earlier patch.

Not sure why I haven't given a tag on this one before now
in either of the patch sets it features in.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
> v1:
> - Change input param from cxlds to cxl_mbox
> - Move mbox_out declaration inline. (Jonathan)
> - Fix __counted_by() input. (Jonathan)
> - Return count for cxl_get_supported_features_count(). (Dan)
> - Remove goto from cxl_get_supported_features(). (Dan)
> - Return cxl_get_supported_feature_entry() directly. (Dan)
> - Drop user path enumeration. (Dan)
> - Move to the feature driver model. (Dan)
> - Add support for 0 feature data requested.
> - Add missing increment of feature data ptr during cop

> diff --git a/drivers/cxl/features.c b/drivers/cxl/features.c
> index 644add26975f..a5949312a4ab 100644
> --- a/drivers/cxl/features.c
> +++ b/drivers/cxl/features.c

>  static int cxl_features_probe(struct device *dev)
>  {
>  	struct cxl_features *features = to_cxl_features(dev);
> +	int rc;
> +
>  	struct cxl_features_state *cfs __free(kfree) =
>  		kzalloc(sizeof(*cfs), GFP_KERNEL);
> -
Stray change that belongs in earlier patch if anywhere.


>  	if (!cfs)
>  		return -ENOMEM;
>  
>  	cfs->features = features;
> +	rc = cxl_get_supported_features(cfs);
> +	if (rc)
> +		return rc;
> +
>  	dev_set_drvdata(dev, no_free_ptr(cfs));
>  
>  	return 0;