All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: steven@liquorix.net
Cc: oe-kbuild-all@lists.linux.dev
Subject: [zen:6.13/bbr3 1/1] net/ipv4/tcp_bbr.c:2042:17: warning: variable 'round_delivered' set but not used
Date: Thu, 23 Jan 2025 23:06:56 +0800	[thread overview]
Message-ID: <202501232307.PyIqUnCG-lkp@intel.com> (raw)

tree:   https://github.com/zen-kernel/zen-kernel 6.13/bbr3
head:   aa2658ab3fba8f0f16c6d9c838776502980974ed
commit: aa2658ab3fba8f0f16c6d9c838776502980974ed [1/1] tcp/bbr3: initial import
config: arc-randconfig-001-20250123 (https://download.01.org/0day-ci/archive/20250123/202501232307.PyIqUnCG-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250123/202501232307.PyIqUnCG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501232307.PyIqUnCG-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/ipv4/tcp_bbr.c: In function 'bbr_main':
>> net/ipv4/tcp_bbr.c:2042:17: warning: variable 'round_delivered' set but not used [-Wunused-but-set-variable]
    2042 |         u32 bw, round_delivered;
         |                 ^~~~~~~~~~~~~~~


vim +/round_delivered +2042 net/ipv4/tcp_bbr.c

  2035	
  2036	__bpf_kfunc static void bbr_main(struct sock *sk, u32 ack, int flag, const struct rate_sample *rs)
  2037	{
  2038		struct tcp_sock *tp = tcp_sk(sk);
  2039		struct bbr *bbr = inet_csk_ca(sk);
  2040		struct bbr_context ctx = { 0 };
  2041		bool update_model = true;
> 2042		u32 bw, round_delivered;
  2043		int ce_ratio = -1;
  2044	
  2045		round_delivered = bbr_update_round_start(sk, rs, &ctx);
  2046		if (bbr->round_start) {
  2047			bbr->rounds_since_probe =
  2048				min_t(s32, bbr->rounds_since_probe + 1, 0xFF);
  2049			ce_ratio = bbr_update_ecn_alpha(sk);
  2050		}
  2051		bbr_plb(sk, rs, ce_ratio);
  2052	
  2053		bbr->ecn_in_round  |= (bbr->ecn_eligible && rs->is_ece);
  2054		bbr_calculate_bw_sample(sk, rs, &ctx);
  2055		bbr_update_latest_delivery_signals(sk, rs, &ctx);
  2056	
  2057		if (bbr_run_fast_path(sk, &update_model, rs, &ctx))
  2058			goto out;
  2059	
  2060		if (update_model)
  2061			bbr_update_model(sk, rs, &ctx);
  2062	
  2063		bbr_update_gains(sk);
  2064		bw = bbr_bw(sk);
  2065		bbr_set_pacing_rate(sk, bw, bbr->pacing_gain);
  2066		bbr_set_cwnd(sk, rs, rs->acked_sacked, bw, bbr->cwnd_gain,
  2067			     tcp_snd_cwnd(tp), &ctx);
  2068		bbr_bound_cwnd_for_inflight_model(sk);
  2069	
  2070	out:
  2071		bbr_advance_latest_delivery_signals(sk, rs, &ctx);
  2072		bbr->prev_ca_state = inet_csk(sk)->icsk_ca_state;
  2073		bbr->loss_in_cycle |= rs->lost > 0;
  2074		bbr->ecn_in_cycle  |= rs->delivered_ce > 0;
  2075	}
  2076	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2025-01-23 15:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202501232307.PyIqUnCG-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=steven@liquorix.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.