From: Stephen Hemminger <stephen@networkplumber.org>
To: Dengdui Huang <huangdengdui@huawei.com>
Cc: <dev@dpdk.org>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>,
<haijie1@huawei.com>, <liuyonglong@huawei.com>
Subject: Re: [PATCH] mbuf: add packet offload Rx flag for keep CRC
Date: Fri, 24 Jan 2025 09:34:36 -0800 [thread overview]
Message-ID: <20250124093436.78d9c232@hermes.local> (raw)
In-Reply-To: <20250124095957.3496874-1-huangdengdui@huawei.com>
On Fri, 24 Jan 2025 17:59:57 +0800
Dengdui Huang <huangdengdui@huawei.com> wrote:
> diff --git a/lib/mbuf/rte_mbuf.c b/lib/mbuf/rte_mbuf.c
> index 559d5ad8a7..c828200ea1 100644
> --- a/lib/mbuf/rte_mbuf.c
> +++ b/lib/mbuf/rte_mbuf.c
> @@ -771,7 +771,7 @@ const char *rte_get_rx_ol_flag_name(uint64_t mask)
> case RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD: return "RTE_MBUF_F_RX_OUTER_L4_CKSUM_GOOD";
> case RTE_MBUF_F_RX_OUTER_L4_CKSUM_INVALID:
> return "RTE_MBUF_F_RX_OUTER_L4_CKSUM_INVALID";
> -
> + case RTE_MBUF_F_RX_KEEP_CRC: return "RTE_MBUF_F_RX_KEEP_CRC";
> default: return NULL;
> }
DPDK style is to add break line after the case statement.
Please do it for both cases.
next prev parent reply other threads:[~2025-01-24 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 9:59 [PATCH] mbuf: add packet offload Rx flag for keep CRC Dengdui Huang
2025-01-24 14:34 ` Morten Brørup
2025-02-07 6:37 ` huangdengdui
2025-01-24 17:34 ` Stephen Hemminger [this message]
2025-02-07 6:37 ` huangdengdui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250124093436.78d9c232@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=haijie1@huawei.com \
--cc=huangdengdui@huawei.com \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.