All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Penkler <dpenkler@gmail.com>
To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Cc: Dave Penkler <dpenkler@gmail.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Jaroslav Kysela <perex@perex.cz>, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH 2/3] pnp: isapnp: Export isapnp_read_byte again
Date: Fri, 24 Jan 2025 11:58:59 +0100	[thread overview]
Message-ID: <20250124105900.27592-3-dpenkler@gmail.com> (raw)
In-Reply-To: <20250124105900.27592-1-dpenkler@gmail.com>

The build of drivers/staging/gpib/hp_82341 driver was failing
with:

ERROR: modpost: "isapnp_read_byte"
[drivers/staging/gpib/hp_82341/hp_82341.ko] undefined!

because the symbol was not exported for modules.

There were no errors building with allyesconfig

The symbol was removed by
Link: https://lore.kernel.org/all/20051030202734.GN4180@stusta.de/
because it was no longer used by any mainline modules.

Export the symbol again.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/r/20241014162054.2b91b5af@canb.auug.org.au
Cc: Jaroslav Kysela <perex@perex.cz> (maintainer:ISAPNP)
Cc: Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
 drivers/pnp/isapnp/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pnp/isapnp/core.c b/drivers/pnp/isapnp/core.c
index c43d8ad02529..d2ff76e74a05 100644
--- a/drivers/pnp/isapnp/core.c
+++ b/drivers/pnp/isapnp/core.c
@@ -843,6 +843,7 @@ EXPORT_SYMBOL(isapnp_protocol);
 EXPORT_SYMBOL(isapnp_present);
 EXPORT_SYMBOL(isapnp_cfg_begin);
 EXPORT_SYMBOL(isapnp_cfg_end);
+EXPORT_SYMBOL(isapnp_read_byte);
 EXPORT_SYMBOL(isapnp_write_byte);
 
 static int isapnp_get_resources(struct pnp_dev *dev)
-- 
2.47.1


  parent reply	other threads:[~2025-01-24 11:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-24 10:58 [PATCH 0/3] staging: gpib: Fix CONFIG_GPIB_HP82341 build failure Dave Penkler
2025-01-24 10:58 ` [PATCH 1/3] staging: gpib: Fix pr_err format warning Dave Penkler
2025-01-24 10:58 ` Dave Penkler [this message]
2025-01-24 10:59 ` [PATCH 3/3] staging: gpib: Remove depends on BROKEN Dave Penkler
2025-01-25 11:39   ` kernel test robot
2025-01-25 14:16   ` kernel test robot
2025-01-26 18:13     ` Dave Penkler
2025-01-25 14:47   ` kernel test robot
2025-01-26 18:18     ` Dave Penkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250124105900.27592-3-dpenkler@gmail.com \
    --to=dpenkler@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=perex@perex.cz \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.