From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4545DC0218C for ; Sat, 25 Jan 2025 21:51:14 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4YgT00370lz30Ss for ; Sun, 26 Jan 2025 08:51:12 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::730" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1737841870; cv=none; b=FyadyzfgIMcYrS9VLkHaamWpnLEz/iRQki6LGH9Sdxn5bLd6y27xslMn45z++ROiVE2parzrRpNkjaTo8ycXSdsnrXyFnS6HnOdTfepeEtlEFG5Ec3hwBKNkvKaIgxzJo02q/ZhdSTzmXQqGmyeCHDV1PinwoJAo+YlQBn0q4EyS7+mXNQsJrx2PEXm3+qe59aIqMhI+dsR/UvjjLE3TUxRaipCwfCYGQ1miCtgucUIivJTfkRJF3FuA2oGmTQ++pMOtu9cONcqBgI32BL68GwDn2Z02E2UuRixqJMvIlGnagfSJ8D3/v6V9ziwcMeum5xOcghx72uwHk2N4t0OHjg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1737841870; c=relaxed/relaxed; bh=RCItPAumNi3YkPwAhGuoBy61cd38EX/U8qv2kfxS+Pg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CFjUZPqWND1U38dSqk79bYAUeTjY58piu/CUBCAhTBtYPvmI+HSrD3KdxI7JlE+zvdHtJ85NdQBde8cP45FEv3+TsDdUu2+kkZGQ2UrS/o785r5qNoRM8MU/vpx94rq3BBRRW2vb3uzPQYhtFY5NZjRdovXgrSbv/efUXoEAxlx/5esH84bOG6yCH0Evz1r/TgwmTZUtsyeF55D7GGGhXYU4XnL/pcwwpvn9ujpyJ4b9xqj7+uMDMC6CDjdI1iACnCMkwcSC+YlHytKuMcmpmPM2g2YZFj/v1EyKr+4pCtUh2uFkwPtlEsbas6qMUzNQk4wQ9rj6mDhaZ5aXyoYdrQ== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=konsulko.com; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=uMvezN2E; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::730; helo=mail-qk1-x730.google.com; envelope-from=trini@konsulko.com; receiver=lists.ozlabs.org) smtp.mailfrom=konsulko.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=uMvezN2E; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=konsulko.com (client-ip=2607:f8b0:4864:20::730; helo=mail-qk1-x730.google.com; envelope-from=trini@konsulko.com; receiver=lists.ozlabs.org) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4YgSzt0Ngwz2xsW for ; Sun, 26 Jan 2025 08:51:04 +1100 (AEDT) Received: by mail-qk1-x730.google.com with SMTP id af79cd13be357-7b6e5ee6ac7so280483885a.0 for ; Sat, 25 Jan 2025 13:51:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1737841862; x=1738446662; darn=lists.ozlabs.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RCItPAumNi3YkPwAhGuoBy61cd38EX/U8qv2kfxS+Pg=; b=uMvezN2EWllYvJAdnVn3lPmn9HXmicX+8pmHrd1K6pvQR2ZPWMSUDWFXcjYDOk8e/x yDlpT3DzjrBeRFBTRaaBmXbfnvin+p+80um1W8jiGAv8oV9BeIYrsFAmkxADVSVClzVv Xrjr0IuPUVzRlD+6E775CDM/BsyeDV2pGhv4Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737841862; x=1738446662; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RCItPAumNi3YkPwAhGuoBy61cd38EX/U8qv2kfxS+Pg=; b=dfOweD9zxQbpOjPEfLnel70TeR2F11a0GVH6z4I5LOqNRbnpqviLrq/opHbhdl+MTI VEpYF+s89rlBfqYOz7MirKOAw/+0BzGo0l35Gh1u7FS6BdyqUMca3kcOYMOYvkvwBPg/ sUroOkJCOb03yd9cM6F07eziwCP+u0ijFnVIPlCRNNSRMcVR5CSRCIJaGbnCOkzts6ZD yD7m+t5188W48EJB4d2FOFxBsBzLPr4oYPMp736p+raVeRwMyrDP3kZIe4Ah2LEPkN8b K50T6yUSxsYuLogELYgWakDPsu2lEZN8Ho8y8gy7+wHoD2KZav18jxiPfbIMLgtE6asu xB4Q== X-Forwarded-Encrypted: i=1; AJvYcCVFO/LFOgoHfhT4NxZ2Er6j+MSeOZ1666FWplo7ZJd4NElUagqi5oajWQMw4W5/4UUKAreIhQJufjlUcg==@lists.ozlabs.org X-Gm-Message-State: AOJu0YxleLqO9zchFKN/2A9BfyekASW1V7WED5QKynFsxoYqMQe1w88A +oGXUH8oRJnPgUGWTN8t394mzXia+S4F9NY9W46OO7fWI/8cabo+i0DYokTY7iM= X-Gm-Gg: ASbGnct4E+M5NWpJ60r/zRYFKSGKivs07eSUsLAj4WZO0U7a0qCVjFx2age074gI76R n0vYFZeXTcG0qLc7sLoC+pH8PU7Xt+iSOlyZJW8O//ZKhhslcq+avpc8gonD9lNkJTCCQtUGndp twS4VHzXR2DD6wP7vxSIZccCCGAx1jRU+jK81h4YmbCATe5Aq/WwuCaWSjjFBwE2SyM/rqjCuKM n9WfDlzDNpTiMboW5euvdm2Mw245khnyszapsR1t8womPK+6Xv4iC4YmDkd2IAMbWp6g+WUB0SB N1OI X-Google-Smtp-Source: AGHT+IHeK4cv2sXskxlDG8IFY7pxHg4PO1aDJJb7l3aMTWxfgOQSxnxX4eBZRNGqvA1WVhOADmEFgg== X-Received: by 2002:a05:620a:19a1:b0:7b6:6701:7a4d with SMTP id af79cd13be357-7be6328a7e0mr5997376585a.56.1737841861972; Sat, 25 Jan 2025 13:51:01 -0800 (PST) Received: from bill-the-cat ([189.177.145.20]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7be9ae975a3sm230948485a.49.2025.01.25.13.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jan 2025 13:51:00 -0800 (PST) Date: Sat, 25 Jan 2025 15:50:55 -0600 From: Tom Rini To: Simon Glass Subject: Re: [PATCH 1/4] test/py: Shorten u_boot_console Message-ID: <20250125215055.GF60249@bill-the-cat> References: <20250125213150.1608395-1-sjg@chromium.org> <20250125213150.1608395-2-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cKP0ipwRxRNGqurb" Content-Disposition: inline In-Reply-To: <20250125213150.1608395-2-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Rokosov , Joao Marcos Costa , Guillaume La Roque , Thomas Petazzoni , Miquel Raynal , Patrick Rudolph , William Zhang , Stephen Warren , Sean Anderson , Richard Weinberger , Michal Simek , Peter Robinson , Roger Knecht , Julien Masson , Weizhao Ouyang , Jerome Forissier , Stephen Warren , Tim Harvey , Love Kumar , Igor Opaniuk , Sam Protsenko , Andrew Goodbody , Caleb Connolly , U-Boot Mailing List , Mattijs Korpershoek , Padmarao Begari , Heinrich Schuchardt , linux-erofs@lists.ozlabs.org, Jens Wiklander Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" --cKP0ipwRxRNGqurb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 25, 2025 at 02:31:36PM -0700, Simon Glass wrote: > This fixture name is quite long and results in lots of verbose code. > We know this is U-Boot so the 'u_boot_' part is not necessary. >=20 > But it is also a bit of a misnomer, since it provides access to all the > information available to tests. It is not just the console. >=20 > It would be too confusing to use con as it would be confused with > config and it is probably too short. >=20 > So shorten it to 'ubpy'. >=20 > Signed-off-by: Simon Glass [snip] > 102 files changed, 2591 insertions(+), 2591 deletions(-) First, I'm not sure I like "ubpy". I believe "u_boot_console" is because it's how we interact with the stdin/stdout of the running U-Boot. And indeed it provides more than that. But ubpy is too abstract and unclear, and looking at the diffstat, I don't know that big global rename is justified to save text space. --=20 Tom --cKP0ipwRxRNGqurb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmeVXL8ACgkQFHw5/5Y0 tywwUgwAmCv9+cbELcIz5xmY51Ptx1hbkOc8rIb+WeKSZQ7cFhIqTVMnzhhYZSq+ BGT6YUm5pkX+YBrSPSfhMGnPQ+ih5s/gAeVukiMGx75yqDF0fo5WHlnw/VgUHTnL IpB5ey0sUWUXvhC1BvnKY8gT1SQpdP3594C1NYujUz4sExWJ7Q6mPHSnuxs7Lcax 6dJiKJyLsGEQPVtcH28uj9UOyJumdF7XG/ixgON5Pwzlw9koypzLGmOSz+9OXXHI VnK4MwurWUuwzGguelnngfsDgmDPYtpVm5DxPlpSedHNRhMF6AisqQUqRdV6XbCp yLncbxFCRRjDlSl8i+4GmZgN8Pm6hKGQ/qBQw/z0veGuzuBp8fpFqEfp0EXubtwl ZeWvOjHnnM+MHDd05U6aArTstWj4pDAOeD8FfwSFEXhtJ/MyVdVSTM9955hyaUB9 Ss0c4xTDiX21fPpDaoV1zQIy+B0dT0bVcmoUL0PFKD4lTRhMn6xfaGiY1fOPXYuG 5luOhSNh =P8FY -----END PGP SIGNATURE----- --cKP0ipwRxRNGqurb-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5A50C0218C for ; Sat, 25 Jan 2025 21:51:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5858C80EC0; Sat, 25 Jan 2025 22:51:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="mrm0LjLD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 970BC80EF4; Sat, 25 Jan 2025 22:51:07 +0100 (CET) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3728280C91 for ; Sat, 25 Jan 2025 22:51:03 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x729.google.com with SMTP id af79cd13be357-7b6e5ee6ac7so280483785a.0 for ; Sat, 25 Jan 2025 13:51:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1737841862; x=1738446662; darn=lists.denx.de; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RCItPAumNi3YkPwAhGuoBy61cd38EX/U8qv2kfxS+Pg=; b=mrm0LjLDQkiQvh4Vx7iYhvn2iMgeiN+A4hcbsHbw+Juevk/XzEvKMJrA9SRQJ+47Or +V7ejiLRJEWy7LMumUhKJ6Ilre7WOQ5CkwPZozCHEOAM2htImGxXVANaW/WfaA0AHrYR X8GVnmyfNvF5NYX0FwzKHnEwOM7HkHtD3V7mw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737841862; x=1738446662; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RCItPAumNi3YkPwAhGuoBy61cd38EX/U8qv2kfxS+Pg=; b=gtQFIAvmqbz6itgQjLcZxFQG01RSJwSpeiJJhRlkTEdAg5SH+lh1dx2W5o2WMgVVnl hfJjsWdHEjQu6Don/ZF6bbYLpCh9ei1NWUBN3UyT09sB1A3ql+NigHdNA5XasEXyXvki mnc1Uks0pnFDveauKewpW2/posBaKR/CwJoqSUz7YSjSCUL2Vrn+VfYRADbZG3L+rMuM RdXVBpy7taicSpknXSM/yee8QjIGsAPPwj5ZEpC0DvBk6zcPAU8WeAtqAUtyikLCRD/y yTFT59zHvNaUG+CpzWGN1Udt/pQTgAKEzIzqFl8KvWpwu9z4MmgJlTl8KbpUIOOGsWin OAAg== X-Gm-Message-State: AOJu0YxsP0Ysb+cYdR3H6mB8a4RZmEdkNAruy2d7RO9ugXTqjon/JyVF Q2qDAp1S+r236Uwp1pksElxZFEuZaxjrhPaB4QLlR3q5/+/5chH5P+aCIISiK6k= X-Gm-Gg: ASbGncsK1BbGi5QPERj6lj6ZkHJ4wps4qDBbmHng2Np3cZ0yAFUt1WP1ZKDBUEwwxjI d/8XjZ1U7zIss5gkp1kEqZefh+yfJ/sibkJYyAEBPTEHQSW2rRvbCco8n0LHYIt9k8A8xur37eo wifhXxeC0nM9ZGQqPT9A+t6ts2GqdR1GVoJn79twlRIqW583wtjWJZVeHcZANMuL8yPiyxKUtqZ w7kD56fjN00NS3Hc/yWtf4oz54TW4pGyUAReUP4WZAVGXF6MCxlOoJoTL5+tB+2z97BjjIqm+6J i29h X-Google-Smtp-Source: AGHT+IHeK4cv2sXskxlDG8IFY7pxHg4PO1aDJJb7l3aMTWxfgOQSxnxX4eBZRNGqvA1WVhOADmEFgg== X-Received: by 2002:a05:620a:19a1:b0:7b6:6701:7a4d with SMTP id af79cd13be357-7be6328a7e0mr5997376585a.56.1737841861972; Sat, 25 Jan 2025 13:51:01 -0800 (PST) Received: from bill-the-cat ([189.177.145.20]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7be9ae975a3sm230948485a.49.2025.01.25.13.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jan 2025 13:51:00 -0800 (PST) Date: Sat, 25 Jan 2025 15:50:55 -0600 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Andrew Goodbody , Caleb Connolly , Dmitry Rokosov , Guillaume La Roque , Heinrich Schuchardt , Huang Jianan , Igor Opaniuk , Jens Wiklander , Jerome Forissier , Joao Marcos Costa , Julien Masson , Love Kumar , Mattijs Korpershoek , Michal Simek , Miquel Raynal , Padmarao Begari , Patrick Rudolph , Peter Robinson , Richard Weinberger , Roger Knecht , Sam Protsenko , Sean Anderson , Stephen Warren , Stephen Warren , Thomas Petazzoni , Tim Harvey , Weizhao Ouyang , William Zhang , linux-erofs@lists.ozlabs.org Subject: Re: [PATCH 1/4] test/py: Shorten u_boot_console Message-ID: <20250125215055.GF60249@bill-the-cat> References: <20250125213150.1608395-1-sjg@chromium.org> <20250125213150.1608395-2-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cKP0ipwRxRNGqurb" Content-Disposition: inline In-Reply-To: <20250125213150.1608395-2-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --cKP0ipwRxRNGqurb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jan 25, 2025 at 02:31:36PM -0700, Simon Glass wrote: > This fixture name is quite long and results in lots of verbose code. > We know this is U-Boot so the 'u_boot_' part is not necessary. >=20 > But it is also a bit of a misnomer, since it provides access to all the > information available to tests. It is not just the console. >=20 > It would be too confusing to use con as it would be confused with > config and it is probably too short. >=20 > So shorten it to 'ubpy'. >=20 > Signed-off-by: Simon Glass [snip] > 102 files changed, 2591 insertions(+), 2591 deletions(-) First, I'm not sure I like "ubpy". I believe "u_boot_console" is because it's how we interact with the stdin/stdout of the running U-Boot. And indeed it provides more than that. But ubpy is too abstract and unclear, and looking at the diffstat, I don't know that big global rename is justified to save text space. --=20 Tom --cKP0ipwRxRNGqurb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmeVXL8ACgkQFHw5/5Y0 tywwUgwAmCv9+cbELcIz5xmY51Ptx1hbkOc8rIb+WeKSZQ7cFhIqTVMnzhhYZSq+ BGT6YUm5pkX+YBrSPSfhMGnPQ+ih5s/gAeVukiMGx75yqDF0fo5WHlnw/VgUHTnL IpB5ey0sUWUXvhC1BvnKY8gT1SQpdP3594C1NYujUz4sExWJ7Q6mPHSnuxs7Lcax 6dJiKJyLsGEQPVtcH28uj9UOyJumdF7XG/ixgON5Pwzlw9koypzLGmOSz+9OXXHI VnK4MwurWUuwzGguelnngfsDgmDPYtpVm5DxPlpSedHNRhMF6AisqQUqRdV6XbCp yLncbxFCRRjDlSl8i+4GmZgN8Pm6hKGQ/qBQw/z0veGuzuBp8fpFqEfp0EXubtwl ZeWvOjHnnM+MHDd05U6aArTstWj4pDAOeD8FfwSFEXhtJ/MyVdVSTM9955hyaUB9 Ss0c4xTDiX21fPpDaoV1zQIy+B0dT0bVcmoUL0PFKD4lTRhMn6xfaGiY1fOPXYuG 5luOhSNh =P8FY -----END PGP SIGNATURE----- --cKP0ipwRxRNGqurb--