Re: [PATCH v1] virtio-net: Fix to avoid using reserved feature bits

["Michael S. Tsirkin" <mst@redhat.com>]

On Sun, Jan 26, 2025 at 04:44:51PM +0000, Parav Pandit wrote:
> 
> 
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Sunday, January 26, 2025 2:50 PM
> > 
> > On Sun, Jan 26, 2025 at 08:20:58AM +0200, Parav Pandit wrote:
> > > Listed patches in the fixes tag, incorrectly used the reserved feature bits.
> > > Fix them to use the well defined device specific range.
> > >
> > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/212
> > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/213
> > > Fixes: 8cd457d8aa82 ("virtio-net: define UDP tunnel segmentation
> > > offload feature")
> > > Fixes: 3fea589bd7c6 ("virtio-net: define UDP tunnel checksum offload
> > > feature")
> > 
> > 
> > Well the hashes will be wrong I think.
> I pulled the patches from the mailing list to local repo using b4.
> Once the new fix is voted, I will merge both the series together so that hashes stays the same.

ok. just make sure to verify them before you push.

> > So, we can do the ballot for this fixup, and wait with applying the patches
> > until that new ballot completes.
> Yes. The small fix is reviewed by Paolo and Cornelia, so if it looks ok, we can wait for this week for any additional review comments.
> And merge by Feb-10 or so after new ballot completes.


Acked-by: Michael S. Tsirkin <mst@redhat.com>

> > Or we can do a completely new ballot.
> > 
> > > Signed-off-by: Parav Pandit <parav@nvidia.com>
> > > Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> > >
> > > ---
> > > changelog:
> > > v0->v1:
> > > - added Cornelia's reviewed-by
> > > - added github issue number
> > > - skipped Paolo's suggestion to modify 'le64 offloads' as its only 64-bits
> > >   and new feature bits are in > 64 bits range
> > > ---
> > >  device-types/net/description.tex | 24 ++++++++++++------------
> > >  1 file changed, 12 insertions(+), 12 deletions(-)
> > >
> > > diff --git a/device-types/net/description.tex
> > > b/device-types/net/description.tex
> > > index efb543f..b546cd7 100644
> > > --- a/device-types/net/description.tex
> > > +++ b/device-types/net/description.tex
> > > @@ -88,18 +88,6 @@ \subsection{Feature bits}\label{sec:Device Types /
> > > Network Device / Feature bits  \item[VIRTIO_NET_F_CTRL_MAC_ADDR(23)]
> > Set MAC address through control
> > >      channel.
> > >
> > > -\item[VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO (46)] Driver can receive
> > GSO
> > > packets
> > > -  carried by a UDP tunnel.
> > > -
> > > -\item[VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM (47)] Driver
> > handles
> > > packets
> > > -  carried by a UDP tunnel with partial csum for the outer header.
> > > -
> > > -\item[VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO (48)] Device can receive
> > GSO
> > > packets
> > > -  carried by a UDP tunnel.
> > > -
> > > -\item[VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO_CSUM (49)] Device
> > handles
> > > packets
> > > -  carried by a UDP tunnel with partial csum for the outer header.
> > > -
> > >  \item[VIRTIO_NET_F_DEVICE_STATS(50)] Device can provide device-level
> > statistics
> > >      to the driver through the control virtqueue.
> > >
> > > @@ -136,6 +124,18 @@ \subsection{Feature bits}\label{sec:Device Types
> > > / Network Device / Feature bits  \item[VIRTIO_NET_F_SPEED_DUPLEX(63)]
> > Device reports speed and duplex.
> > >
> > >  \item[VIRTIO_NET_F_RSS_CONTEXT(64)] Device supports multiple RSS
> > contexts.
> > > +
> > > +\item[VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO (65)] Driver can receive
> > GSO
> > > +packets
> > > +  carried by a UDP tunnel.
> > > +
> > > +\item[VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM (66)] Driver
> > handles
> > > +packets
> > > +  carried by a UDP tunnel with partial csum for the outer header.
> > > +
> > > +\item[VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO (67)] Device can receive
> > GSO
> > > +packets
> > > +  carried by a UDP tunnel.
> > > +
> > > +\item[VIRTIO_NET_F_HOST_UDP_TUNNEL_GSO_CSUM (68)] Device
> > handles
> > > +packets
> > > +  carried by a UDP tunnel with partial csum for the outer header.
> > >  \end{description}
> > >
> > >  \subsubsection{Feature bit requirements}\label{sec:Device Types /
> > > Network Device / Feature bits / Feature bit requirements}
> > > --
> > > 2.34.1