From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Vincent Jardin <vjardin@free.fr>
Cc: buildroot@buildroot.org,
Eric Le Bihan <eric.le.bihan.dev@free.fr>,
Robin Jarry <robin@jarry.cc>,
Brandon Maier <brandon.maier@gmail.com>,
Julien Olivain <ju.o@free.fr>
Subject: Re: [Buildroot] [PATCH v6 1/2] package/pkg-meson: h files only into sysroot
Date: Sun, 26 Jan 2025 12:14:18 +0100 [thread overview]
Message-ID: <20250126121418.28a0e655@windsurf> (raw)
In-Reply-To: <20250102164630.25695-2-vjardin@free.fr>
Hello,
On Thu, 2 Jan 2025 17:46:29 +0100
Vincent Jardin <vjardin@free.fr> wrote:
> Many packages built with Buildroot and meson currently install header
> files into both:
> - the target’s /usr/include, and
> - the sysroot’s /usr/include.
>
> When FOO_MESON_INSTALL_TAGS = YES, ensure that header files are
> installed exclusively in the staging (sysroot) target during the
> build process.
>
> The default is FOO_MESON_INSTALL_TAGS ?= NO in order to avoid
> changing to this new behaviour for the time being.
>
> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> Suggested-by: Robin Jarry <robin@jarry.cc>
> Suggested-by: Brandon Maier <brandon.maier@gmail.com>
Thanks Vincent for the patch.
I am not sure we want this behavior, as it would only be applicable to
meson packages. For all other packages, we install pretty much
everything to target, and then wipe-out what's needed in
target-finalize. So I'm not sure what is the benefit of diverging from
this common behavior just for meson packages.
This is not a strong feeling, but as other build systems don't have
this concept of installing only the runtime, I'm not sure it makes a
lot of sense to use that just for meson-based packages.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-01-26 11:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 20:59 [Buildroot] [PATCH 1/1] package/pkg-meson: h files only into sysroot Vincent Jardin
2024-11-21 13:49 ` Brandon Maier
2024-11-22 0:20 ` Vincent Jardin
2024-11-26 14:17 ` Brandon Maier
2024-11-26 18:10 ` Vincent Jardin
2024-11-26 19:57 ` Brandon Maier
2024-11-27 1:29 ` [Buildroot] [PATCH v2 0/2] meson install with optional tags Vincent Jardin
2024-11-27 1:30 ` [Buildroot] [PATCH v2 1/2] package/pkg-meson: h files only into sysroot Vincent Jardin
2024-11-29 23:42 ` Brandon Maier
2024-12-02 15:39 ` Vincent Jardin
2024-12-02 15:46 ` [Buildroot] [PATCH v3 0/2] meson install with optional tags Vincent Jardin
2024-12-02 15:46 ` [Buildroot] [PATCH v3 1/2] package/pkg-meson: h files only into sysroot Vincent Jardin
2024-12-02 15:46 ` [Buildroot] [PATCH v3 2/2] doc/manual/adding-packages-meson.adoc: tags Vincent Jardin
2024-12-03 14:00 ` [Buildroot] [PATCH v4 0/2] meson install with optional tags Vincent Jardin
2024-12-03 14:00 ` [Buildroot] [PATCH v4 1/2] package/pkg-meson: h files only into sysroot Vincent Jardin
2024-12-06 13:45 ` Brandon Maier
2024-12-06 21:30 ` [Buildroot] [PATCH v5 0/2] meson install with optional tags Vincent Jardin
2024-12-06 21:30 ` [Buildroot] [PATCH v5 1/2] package/pkg-meson: h files only into sysroot Vincent Jardin
2024-12-06 21:30 ` [Buildroot] [PATCH v5 2/2] doc/manual/adding-packages-meson.adoc: tags Vincent Jardin
2024-12-10 0:08 ` Brandon Maier
2025-01-02 16:46 ` [Buildroot] [PATCH v6 0/2] meson install with optional tags Vincent Jardin
2025-01-02 16:46 ` [Buildroot] [PATCH v6 1/2] package/pkg-meson: h files only into sysroot Vincent Jardin
2025-01-10 0:08 ` Brandon Maier
2025-01-26 11:14 ` Thomas Petazzoni via buildroot [this message]
2025-01-02 16:46 ` [Buildroot] [PATCH v6 2/2] doc/manual/adding-packages-meson.adoc: tags Vincent Jardin
2025-01-10 0:09 ` Brandon Maier
2025-01-26 10:23 ` Vincent Jardin
2025-01-26 11:15 ` Thomas Petazzoni via buildroot
2025-01-02 16:50 ` [Buildroot] [PATCH v5 " Vincent Jardin
2024-12-03 14:00 ` [Buildroot] [PATCH v4 " Vincent Jardin
2024-12-06 13:47 ` [Buildroot] [PATCH v2 1/2] package/pkg-meson: h files only into sysroot Brandon Maier
2024-12-06 21:51 ` Vincent Jardin
2024-11-27 1:30 ` [Buildroot] [PATCH v2 2/2] doc/manual/adding-packages-meson.adoc: tags Vincent Jardin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250126121418.28a0e655@windsurf \
--to=buildroot@buildroot.org \
--cc=brandon.maier@gmail.com \
--cc=eric.le.bihan.dev@free.fr \
--cc=ju.o@free.fr \
--cc=robin@jarry.cc \
--cc=thomas.petazzoni@bootlin.com \
--cc=vjardin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.