All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Paalanen <pekka.paalanen@haloniitty.fi>
To: Harry Wentland <harry.wentland@amd.com>
Cc: Alex Hung <alex.hung@amd.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
	wayland-devel@lists.freedesktop.org
Subject: Re: [V7 31/45] drm/colorop: add BT2020/BT709 OETF and Inverse OETF
Date: Mon, 27 Jan 2025 14:05:29 +0200	[thread overview]
Message-ID: <20250127140529.722b376d@eldfell> (raw)
In-Reply-To: <9cc07dc9-ce0d-40cc-ae70-55a1b3f176e2@amd.com>

[-- Attachment #1: Type: text/plain, Size: 2488 bytes --]

On Thu, 23 Jan 2025 15:16:29 -0500
Harry Wentland <harry.wentland@amd.com> wrote:

> On 2025-01-17 04:06, Pekka Paalanen wrote:
> > On Thu, 16 Jan 2025 10:56:22 +0200
> > Pekka Paalanen <pekka.paalanen@haloniitty.fi> wrote:
> >   
> >> On Thu, 19 Dec 2024 21:33:37 -0700
> >> Alex Hung <alex.hung@amd.com> wrote:
> >>  
> >>> From: Harry Wentland <harry.wentland@amd.com>
> >>>
> >>> The BT.709 and BT.2020 OETFs are the same, the only difference
> >>> being that the BT.2020 variant is defined with more precision
> >>> for 10 and 12-bit per color encodings.
> >>>
> >>> Both are used as encoding functions for video content, and are
> >>> therefore defined as OETF (opto-electronic transfer function)
> >>> instead of as EOTF (electro-optical transfer function).
> >>>
> >>> Signed-off-by: Alex Hung <alex.hung@amd.com>
> >>> Signed-off-by: Harry Wentland <harry.wentland@amd.com>    
> >>
> >> Hi,
> >>
> >> why would a display system ever use BT.2020 or BT.709 OETF or its
> >> inverse?  
> > 
> > Sorry, this is more for my own curiosity, not an argument against the
> > patch. Since hardware designers decided to incorporate these curves
> > explicitly, what use was in mind? It's likely something I have
> > overlooked.
> >   
> 
> I'm not entirely sure myself, but gamescope does use it for displaying
> game streaming content.
> 
> https://github.com/ValveSoftware/gamescope/blob/2f88849ac9dc7da5c678d5d7d3e9b58f38add1bf/src/Backends/DRMBackend.cpp#L2509

I see, apparently they are being used as a pair to make a roundtrip to
some optical space for applying a color transformation matrix. IOW, the
CTM is being applied in the assumed "camera" side of broadcasting or
grading.

ITU-R BT.2408 seems to refer to this as "scene referred mapping", whose
aim is to match cameras rather than displays (and has nothing to do
with the scene). I cannot claim to understand this case, but I suspect
it should be used only before color grading (manual or automatic
artistic adjustments, or IOW picture formation(?)) in a pipeline.

I would assume that game streaming content has been prepared for a
display at its source, which implies that grading has been done. That
means that inverse-OETF leads to an unknown color space. Applying a
matrix in an unknown color space has unintended effects. That may not
be a big problem, even less if the matrix is visually adjusted, but
it's theoretically not quite right AFAIU.


Thanks,
pq

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-01-27 12:05 UTC|newest]

Thread overview: 127+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20  4:33 [V7 00/45] Color Pipeline API w/ VKMS Alex Hung
2024-12-20  4:33 ` [V7 01/45] drm: Add helper for conversion from signed-magnitude Alex Hung
2025-02-24 16:07   ` Louis Chauvet
2025-02-24 18:50     ` Alex Hung
2025-02-25  9:35       ` Louis Chauvet
2024-12-20  4:33 ` [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16 Alex Hung
2025-02-24 16:07   ` Louis Chauvet
2025-02-25  9:37   ` Louis Chauvet
2025-02-25 11:28     ` Simon Ser
2025-02-25 14:05       ` Louis Chauvet
2025-02-25 14:43         ` Harry Wentland
2025-02-25 14:45           ` Simon Ser
2025-02-25 16:00             ` Louis Chauvet
2024-12-20  4:33 ` [V7 03/45] drm/vkms: Add kunit tests for VKMS LUT handling Alex Hung
2025-02-24 16:07   ` Louis Chauvet
2025-02-25  9:51   ` Louis Chauvet
2025-02-25 14:45     ` Harry Wentland
2024-12-20  4:33 ` [V7 04/45] drm/doc/rfc: Describe why prescriptive color pipeline is needed Alex Hung
2024-12-20  4:33 ` [V7 05/45] drm/colorop: Introduce new drm_colorop mode object Alex Hung
2025-01-13  8:04   ` Simon Ser
2025-02-24 16:07   ` Louis Chauvet
2025-02-25 10:05   ` Louis Chauvet
2025-02-28 15:55     ` Harry Wentland
2024-12-20  4:33 ` [V7 06/45] drm/colorop: Add TYPE property Alex Hung
2025-01-13  8:05   ` Simon Ser
2025-02-24 16:07   ` Louis Chauvet
2025-02-25 10:07   ` Louis Chauvet
2024-12-20  4:33 ` [V7 07/45] drm/colorop: Add 1D Curve subtype Alex Hung
2025-01-13  8:07   ` Simon Ser
2025-02-24 16:07   ` Louis Chauvet
2025-02-25 10:13   ` Louis Chauvet
2025-02-28  1:07     ` Alex Hung
2025-02-28  9:24       ` Louis Chauvet
2024-12-20  4:33 ` [V7 08/45] Documentation/gpu: document drm_colorop Alex Hung
2025-01-13  8:18   ` Simon Ser
2025-02-10 22:03     ` Harry Wentland
2025-02-15 14:40       ` Simon Ser
2025-02-21 16:18         ` Harry Wentland
2025-02-21 16:42           ` Simon Ser
2025-02-21 18:41             ` Harry Wentland
2025-02-21 18:48               ` Simon Ser
2024-12-20  4:33 ` [V7 09/45] drm/colorop: Add BYPASS property Alex Hung
2025-01-13 17:49   ` Simon Ser
2025-02-24 16:07   ` Louis Chauvet
2025-02-25 10:15   ` Louis Chauvet
2024-12-20  4:33 ` [V7 10/45] drm/colorop: Add NEXT property Alex Hung
2025-01-13 17:54   ` Simon Ser
2025-02-24 16:07   ` Louis Chauvet
2025-02-25 10:21   ` Louis Chauvet
2024-12-20  4:33 ` [V7 11/45] drm/colorop: Add atomic state print for drm_colorop Alex Hung
2025-01-13 17:55   ` Simon Ser
2024-12-20  4:33 ` [V7 12/45] drm/plane: Add COLOR PIPELINE property Alex Hung
2025-01-13 18:08   ` Simon Ser
2024-12-20  4:33 ` [V7 13/45] drm/colorop: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE Alex Hung
2025-01-13 18:23   ` Simon Ser
2025-01-22 19:48     ` Harry Wentland
2025-01-22 20:05       ` Simon Ser
2024-12-20  4:33 ` [V7 14/45] drm/vkms: Add enumerated 1D curve colorop Alex Hung
2025-02-25 11:18   ` Louis Chauvet
2025-03-10 19:43     ` Harry Wentland
2024-12-20  4:33 ` [V7 15/45] drm/vkms: Add kunit tests for linear and sRGB LUTs Alex Hung
2025-02-25 11:19   ` Louis Chauvet
2025-03-10 15:09     ` Harry Wentland
2024-12-20  4:33 ` [V7 16/45] drm/colorop: Add 3x4 CTM type Alex Hung
2025-01-13 18:19   ` Simon Ser
2025-02-25 11:20   ` Louis Chauvet
2024-12-20  4:33 ` [V7 17/45] drm/vkms: Use s32 for internal color pipeline precision Alex Hung
2024-12-20  4:33 ` [V7 18/45] drm/vkms: add 3x4 matrix in color pipeline Alex Hung
2025-02-25 11:21   ` Louis Chauvet
2024-12-20  4:33 ` [V7 19/45] drm/tests: Add a few tests around drm_fixed.h Alex Hung
2024-12-20  4:33 ` [V7 20/45] drm/vkms: Add tests for CTM handling Alex Hung
2024-12-20  4:33 ` [V7 21/45] drm/colorop: pass plane_color_pipeline client cap to atomic check Alex Hung
2024-12-20  4:33 ` [V7 22/45] drm/colorop: define a new macro for_each_new_colorop_in_state Alex Hung
2025-01-15  7:48   ` Simon Ser
2024-12-20  4:33 ` [V7 23/45] drm/amd/display: Ignore deprecated props when plane_color_pipeline set Alex Hung
2025-01-15  7:56   ` Simon Ser
2025-01-22 21:05     ` Harry Wentland
2025-01-23 20:29       ` Simon Ser
2024-12-20  4:33 ` [V7 24/45] drm/amd/display: Add bypass COLOR PIPELINE Alex Hung
2024-12-20  4:33 ` [V7 25/45] drm/amd/display: Skip color pipeline initialization for cursor plane Alex Hung
2024-12-20  4:33 ` [V7 26/45] drm/amd/display: Add support for sRGB EOTF in DEGAM block Alex Hung
2025-02-13 15:35   ` Leo Li
2024-12-20  4:33 ` [V7 27/45] drm/amd/display: Add support for sRGB Inverse EOTF in SHAPER block Alex Hung
2024-12-20  4:33 ` [V7 28/45] drm/amd/display: Add support for sRGB EOTF in BLND block Alex Hung
2024-12-20  4:33 ` [V7 29/45] drm/colorop: Add PQ 125 EOTF and its inverse Alex Hung
2025-01-15  8:00   ` Simon Ser
2025-01-23 20:06     ` Harry Wentland
2025-01-23 20:33       ` Simon Ser
2025-01-17  9:04   ` Pekka Paalanen
2025-01-23 20:09     ` Harry Wentland
2024-12-20  4:33 ` [V7 30/45] drm/amd/display: Enable support for PQ 125 EOTF and Inverse Alex Hung
2024-12-20  4:33 ` [V7 31/45] drm/colorop: add BT2020/BT709 OETF and Inverse OETF Alex Hung
2025-01-15  8:04   ` Simon Ser
2025-01-23 20:13     ` Harry Wentland
2025-01-16  8:56   ` Pekka Paalanen
2025-01-17  9:06     ` Pekka Paalanen
2025-01-23 20:16       ` Harry Wentland
2025-01-27 12:05         ` Pekka Paalanen [this message]
2024-12-20  4:33 ` [V7 32/45] drm/amd/display: Add support for BT.709 and BT.2020 TFs Alex Hung
2025-02-12 23:03   ` Leo Li
2024-12-20  4:33 ` [V7 33/45] drm/colorop: Add 1D Curve Custom LUT type Alex Hung
2025-01-15  8:14   ` Simon Ser
2025-01-16 23:33     ` Alex Hung
2025-01-18 13:54       ` Simon Ser
2025-01-15 15:48   ` Simon Ser
2024-12-20  4:33 ` [V7 34/45] drm/amd/display: add shaper and blend colorops for 1D Curve Custom LUT Alex Hung
2025-02-12 23:44   ` Leo Li
2025-02-21 16:28     ` Harry Wentland
2024-12-20  4:33 ` [V7 35/45] drm/amd/display: add 3x4 matrix colorop Alex Hung
2025-02-13 17:16   ` Leo Li
2024-12-20  4:33 ` [V7 36/45] drm/colorop: Add mutliplier type Alex Hung
2025-01-15 15:54   ` Simon Ser
2024-12-20  4:33 ` [V7 37/45] drm/amd/display: add multiplier colorop Alex Hung
2024-12-20  4:33 ` [V7 38/45] drm/amd/display: Swap matrix and multiplier Alex Hung
2024-12-20  4:33 ` [V7 39/45] drm/colorop: Define LUT_1D interpolation Alex Hung
2025-01-20  7:48   ` Simon Ser
2024-12-20  4:33 ` [V7 40/45] drm/colorop: allow non-bypass colorops Alex Hung
2024-12-20  4:33 ` [V7 41/45] drm/colorop: Add 3D LUT supports to color pipeline Alex Hung
2025-01-20 21:16   ` Simon Ser
2024-12-20  4:33 ` [V7 42/45] drm/amd/display: add 3D LUT colorop Alex Hung
2025-02-13 18:21   ` Leo Li
2025-02-21 21:05     ` Harry Wentland
2024-12-20  4:33 ` [V7 43/45] drm/amd/display: Add AMD color pipeline doc Alex Hung
2025-01-17  9:19   ` Pekka Paalanen
2025-01-23 20:52     ` Harry Wentland
2024-12-20  4:33 ` [V7 44/45] drm/colorop: Add kernel doc for data blob Alex Hung
2024-12-20  4:33 ` [V7 45/45] drm/colorop: Add destroy functions for color pipeline Alex Hung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250127140529.722b376d@eldfell \
    --to=pekka.paalanen@haloniitty.fi \
    --cc=alex.hung@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=wayland-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.