From: Jakub Kicinski <kuba@kernel.org>
To: Sankararaman Jayaraman <sankararaman.jayaraman@broadcom.com>
Cc: netdev@vger.kernel.org, ronak.doshi@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, andrew+netdev@lunn.ch,
davem@davemloft.net, u9012063@gmail.com, edumazet@google.com,
pabeni@redhat.com, ast@kernel.org, alexandr.lobakin@intel.com,
alexanderduyck@fb.com, bpf@vger.kernel.org, daniel@iogearbox.net,
hawk@kernel.org, john.fastabend@gmail.com
Subject: Re: [PATCH net] vmxnet3: Fix tx queue race condition with XDP
Date: Mon, 27 Jan 2025 14:36:35 -0800 [thread overview]
Message-ID: <20250127143635.623dc3b0@kernel.org> (raw)
In-Reply-To: <20250124090211.110328-1-sankararaman.jayaraman@broadcom.com>
On Fri, 24 Jan 2025 14:32:11 +0530 Sankararaman Jayaraman wrote:
> + * Copyright (C) 2008-2025, VMware, Inc. All Rights Reserved.
Please don't update copyright dates in a fix.
It increases the size of the patch and risk of a conflict.
> @@ -123,7 +123,9 @@ vmxnet3_xdp_xmit_frame(struct vmxnet3_adapter *adapter,
> struct page *page;
> u32 buf_size;
> u32 dw2;
> + unsigned long irq_flags;
please order variable declaration lines longest to shortest
> + spin_lock_irqsave(&tq->tx_lock, irq_flags);
why _irqsave() ?
--
pw-bot: cr
next prev parent reply other threads:[~2025-01-27 22:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 9:02 [PATCH net] vmxnet3: Fix tx queue race condition with XDP Sankararaman Jayaraman
2025-01-24 16:45 ` William Tu
2025-01-27 17:01 ` Simon Horman
2025-01-27 22:36 ` Jakub Kicinski [this message]
2025-01-29 17:34 ` Sankararaman Jayaraman
2025-01-29 18:17 ` [PATCH net v2] " Sankararaman Jayaraman
2025-01-30 1:15 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2025-01-08 3:48 [PATCH net] " Sankararaman Jayaraman
2025-01-08 18:13 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127143635.623dc3b0@kernel.org \
--to=kuba@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=alexandr.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ronak.doshi@broadcom.com \
--cc=sankararaman.jayaraman@broadcom.com \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.