From: Jakub Kicinski <kuba@kernel.org>
To: netdev@vger.kernel.org
Cc: Shigeru Yoshida <syoshida@redhat.com>,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
syzkaller <syzkaller@googlegroups.com>
Subject: Re: [PATCH net] vxlan: Fix uninit-value in vxlan_vnifilter_dump()
Date: Mon, 27 Jan 2025 15:01:12 -0800 [thread overview]
Message-ID: <20250127150112.5e395327@kernel.org> (raw)
In-Reply-To: <20250123145746.785768-1-syoshida@redhat.com>
On Thu, 23 Jan 2025 23:57:46 +0900 Shigeru Yoshida wrote:
> + if (cb->nlh->nlmsg_len < nlmsg_msg_size(sizeof(struct tunnel_msg))) {
> + NL_SET_ERR_MSG(cb->extack, "Invalid msg length");
> + return -EINVAL;
> + }
> +
> tmsg = nlmsg_data(cb->nlh);
We really should have a better helper for combined message length
validation and nlmsg_data(). I'll add this to our list of outstanding
cleanup tasks..
next prev parent reply other threads:[~2025-01-27 23:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 14:57 [PATCH net] vxlan: Fix uninit-value in vxlan_vnifilter_dump() Shigeru Yoshida
2025-01-23 21:01 ` Ido Schimmel
2025-01-27 23:01 ` Jakub Kicinski [this message]
2025-01-27 23:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127150112.5e395327@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syoshida@redhat.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.