Re: [PATCH RFC 13/14] ahci: sata_highbank: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr()

[kernel test robot <lkp@intel.com>]

Hi Raphael,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on 5ffa57f6eecefababb8cbe327222ef171943b183]

url:    https://github.com/intel-lab-lkp/linux/commits/Raphael-Gallais-Pou/ahci-brcm-Switch-from-CONFIG_PM_SLEEP-guards-to-pm_sleep_ptr/20250127-205128
base:   5ffa57f6eecefababb8cbe327222ef171943b183
patch link:    https://lore.kernel.org/r/20250127-pm_ata-v1-13-f8f50c821a2a%40gmail.com
patch subject: [PATCH RFC 13/14] ahci: sata_highbank: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr()
config: csky-randconfig-002-20250127 (https://download.01.org/0day-ci/archive/20250127/202501272311.wwRTRF7F-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250127/202501272311.wwRTRF7F-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501272311.wwRTRF7F-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/ata/sata_highbank.c: In function 'ahci_highbank_suspend':
>> drivers/ata/sata_highbank.c:590:9: error: implicit declaration of function 'ata_host_suspend'; did you mean 'ata_sas_port_suspend'? [-Wimplicit-function-declaration]
     590 |         ata_host_suspend(host, PMSG_SUSPEND);
         |         ^~~~~~~~~~~~~~~~
         |         ata_sas_port_suspend
   drivers/ata/sata_highbank.c: In function 'ahci_highbank_resume':
>> drivers/ata/sata_highbank.c:607:9: error: implicit declaration of function 'ata_host_resume'; did you mean 'ahci_port_resume'? [-Wimplicit-function-declaration]
     607 |         ata_host_resume(host);
         |         ^~~~~~~~~~~~~~~
         |         ahci_port_resume


vim +590 drivers/ata/sata_highbank.c

8996b89d6bc98ae Mark Langsdorf  2012-09-06  567  
8996b89d6bc98ae Mark Langsdorf  2012-09-06  568  static int ahci_highbank_suspend(struct device *dev)
8996b89d6bc98ae Mark Langsdorf  2012-09-06  569  {
8996b89d6bc98ae Mark Langsdorf  2012-09-06  570  	struct ata_host *host = dev_get_drvdata(dev);
8996b89d6bc98ae Mark Langsdorf  2012-09-06  571  	struct ahci_host_priv *hpriv = host->private_data;
8996b89d6bc98ae Mark Langsdorf  2012-09-06  572  	void __iomem *mmio = hpriv->mmio;
8996b89d6bc98ae Mark Langsdorf  2012-09-06  573  	u32 ctl;
8996b89d6bc98ae Mark Langsdorf  2012-09-06  574  
8996b89d6bc98ae Mark Langsdorf  2012-09-06  575  	if (hpriv->flags & AHCI_HFLAG_NO_SUSPEND) {
8996b89d6bc98ae Mark Langsdorf  2012-09-06  576  		dev_err(dev, "firmware update required for suspend/resume\n");
8996b89d6bc98ae Mark Langsdorf  2012-09-06  577  		return -EIO;
8996b89d6bc98ae Mark Langsdorf  2012-09-06  578  	}
8996b89d6bc98ae Mark Langsdorf  2012-09-06  579  
8996b89d6bc98ae Mark Langsdorf  2012-09-06  580  	/*
8996b89d6bc98ae Mark Langsdorf  2012-09-06  581  	 * AHCI spec rev1.1 section 8.3.3:
8996b89d6bc98ae Mark Langsdorf  2012-09-06  582  	 * Software must disable interrupts prior to requesting a
8996b89d6bc98ae Mark Langsdorf  2012-09-06  583  	 * transition of the HBA to D3 state.
8996b89d6bc98ae Mark Langsdorf  2012-09-06  584  	 */
8996b89d6bc98ae Mark Langsdorf  2012-09-06  585  	ctl = readl(mmio + HOST_CTL);
8996b89d6bc98ae Mark Langsdorf  2012-09-06  586  	ctl &= ~HOST_IRQ_EN;
8996b89d6bc98ae Mark Langsdorf  2012-09-06  587  	writel(ctl, mmio + HOST_CTL);
8996b89d6bc98ae Mark Langsdorf  2012-09-06  588  	readl(mmio + HOST_CTL); /* flush */
8996b89d6bc98ae Mark Langsdorf  2012-09-06  589  
ec87cf3782f7b05 Sergey Shtylyov 2022-02-02 @590  	ata_host_suspend(host, PMSG_SUSPEND);
ec87cf3782f7b05 Sergey Shtylyov 2022-02-02  591  	return 0;
8996b89d6bc98ae Mark Langsdorf  2012-09-06  592  }
8996b89d6bc98ae Mark Langsdorf  2012-09-06  593  
8996b89d6bc98ae Mark Langsdorf  2012-09-06  594  static int ahci_highbank_resume(struct device *dev)
8996b89d6bc98ae Mark Langsdorf  2012-09-06  595  {
8996b89d6bc98ae Mark Langsdorf  2012-09-06  596  	struct ata_host *host = dev_get_drvdata(dev);
8996b89d6bc98ae Mark Langsdorf  2012-09-06  597  	int rc;
8996b89d6bc98ae Mark Langsdorf  2012-09-06  598  
8996b89d6bc98ae Mark Langsdorf  2012-09-06  599  	if (dev->power.power_state.event == PM_EVENT_SUSPEND) {
8996b89d6bc98ae Mark Langsdorf  2012-09-06  600  		rc = ahci_reset_controller(host);
8996b89d6bc98ae Mark Langsdorf  2012-09-06  601  		if (rc)
8996b89d6bc98ae Mark Langsdorf  2012-09-06  602  			return rc;
8996b89d6bc98ae Mark Langsdorf  2012-09-06  603  
8996b89d6bc98ae Mark Langsdorf  2012-09-06  604  		ahci_init_controller(host);
8996b89d6bc98ae Mark Langsdorf  2012-09-06  605  	}
8996b89d6bc98ae Mark Langsdorf  2012-09-06  606  
8996b89d6bc98ae Mark Langsdorf  2012-09-06 @607  	ata_host_resume(host);
8996b89d6bc98ae Mark Langsdorf  2012-09-06  608  
8996b89d6bc98ae Mark Langsdorf  2012-09-06  609  	return 0;
8996b89d6bc98ae Mark Langsdorf  2012-09-06  610  }
8996b89d6bc98ae Mark Langsdorf  2012-09-06  611  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki