From: Christoph Hellwig <hch@lst.de>
To: Zhang Yi <yi.zhang@huaweicloud.com>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-block@vger.kernel.org, dm-devel@lists.linux.dev,
linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, hch@lst.de, tytso@mit.edu,
djwong@kernel.org, yi.zhang@huawei.com, chengzhihao1@huawei.com,
yukuai3@huawei.com, yangerkun@huawei.com
Subject: Re: [RFC PATCH v2 3/8] scsi: sd: set BLK_FEAT_WRITE_ZEROES_UNMAP if device supports unmap zeroing mode
Date: Tue, 28 Jan 2025 07:47:20 +0100 [thread overview]
Message-ID: <20250128064720.GC21401@lst.de> (raw)
In-Reply-To: <20250115114637.2705887-4-yi.zhang@huaweicloud.com>
On Wed, Jan 15, 2025 at 07:46:32PM +0800, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@huawei.com>
>
> When the device supports the Write Zeroes command and the zeroing mode
> is set to SD_ZERO_WS16_UNMAP or SD_ZERO_WS10_UNMAP, this means that the
> device supports unmap Write Zeroes, so set the corresponding
> BLK_FEAT_WRITE_ZEROES_UNMAP feature to the device's queue limit.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-01-28 6:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 11:46 [RFC PATCH v2 0/8] fallocate: introduce FALLOC_FL_WRITE_ZEROES flag Zhang Yi
2025-01-15 11:46 ` [RFC PATCH v2 1/8] block: introduce BLK_FEAT_WRITE_ZEROES_UNMAP to queue limits features Zhang Yi
2025-01-28 6:44 ` Christoph Hellwig
2025-01-28 16:46 ` John Garry
2025-02-07 12:22 ` Zhang Yi
2025-02-07 12:31 ` Zhang Yi
2025-01-15 11:46 ` [RFC PATCH v2 2/8] nvme: set BLK_FEAT_WRITE_ZEROES_UNMAP if device supports DEAC bit Zhang Yi
2025-01-28 6:46 ` Christoph Hellwig
2025-02-07 12:24 ` Zhang Yi
2025-01-15 11:46 ` [RFC PATCH v2 3/8] scsi: sd: set BLK_FEAT_WRITE_ZEROES_UNMAP if device supports unmap zeroing mode Zhang Yi
2025-01-28 6:47 ` Christoph Hellwig [this message]
2025-01-15 11:46 ` [RFC PATCH v2 4/8] dm: add BLK_FEAT_WRITE_ZEROES_UNMAP support Zhang Yi
2025-02-07 22:14 ` Benjamin Marzinski
2025-02-08 3:12 ` Zhang Yi
2025-02-10 22:34 ` Benjamin Marzinski
2025-01-15 11:46 ` [RFC PATCH v2 5/8] fs: introduce FALLOC_FL_WRITE_ZEROES to fallocate Zhang Yi
2025-01-15 11:46 ` [RFC PATCH v2 6/8] block: add FALLOC_FL_WRITE_ZEROES support Zhang Yi
2025-01-15 11:46 ` [RFC PATCH v2 7/8] block: factor out common part in blkdev_fallocate() Zhang Yi
2025-01-15 11:46 ` [RFC PATCH v2 8/8] ext4: add FALLOC_FL_WRITE_ZEROES support Zhang Yi
2025-01-15 21:07 ` [RFC PATCH v2 0/8] fallocate: introduce FALLOC_FL_WRITE_ZEROES flag Chaitanya Kulkarni
2025-01-16 3:04 ` Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128064720.GC21401@lst.de \
--to=hch@lst.de \
--cc=chengzhihao1@huawei.com \
--cc=djwong@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yi.zhang@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.