From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@meta.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de, sagi@grimberg.me,
hare@suse.de, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: make nvme_tls_attrs_group static
Date: Tue, 28 Jan 2025 16:27:46 +0100 [thread overview]
Message-ID: <20250128152746.GA26292@lst.de> (raw)
In-Reply-To: <20250128152512.771115-1-kbusch@meta.com>
On Tue, Jan 28, 2025 at 07:25:12AM -0800, Keith Busch wrote:
> From: Keith Busch <kbusch@kernel.org>
>
> To suppress the compiler "warning: symbol 'nvme_tls_attrs_group' was not
> declared. Should it be static?"
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-01-28 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 15:25 [PATCH] nvme: make nvme_tls_attrs_group static Keith Busch
2025-01-28 15:27 ` Christoph Hellwig [this message]
2025-01-28 21:46 ` Chaitanya Kulkarni
2025-01-31 8:17 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128152746.GA26292@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.