From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: zlang@kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] generic/418: use min_dio_alignment
Date: Tue, 28 Jan 2025 11:21:47 -0800 [thread overview]
Message-ID: <20250128192147.GS3557695@frogsfrogsfrogs> (raw)
In-Reply-To: <20250128071412.676396-1-hch@lst.de>
On Tue, Jan 28, 2025 at 08:14:12AM +0100, Christoph Hellwig wrote:
> Otherwise this test uses the wrong sector size on the RT device.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> tests/generic/418 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/418 b/tests/generic/418
> index 4321e2984663..36789198c88e 100755
> --- a/tests/generic/418
> +++ b/tests/generic/418
> @@ -28,7 +28,7 @@ _require_test_program "feature"
>
> diotest=$here/src/dio-invalidate-cache
> testfile=$TEST_DIR/$seq-diotest
> -sectorsize=`blockdev --getss $TEST_DEV`
> +sectorsize=`$here/src/min_dio_alignment $TEST_DIR $TEST_DEV`
BTW is min_dio_alignment going to get an upgrade to report
STATX_DIO_READ_ALIGN ?
The changes here look correct to me
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> pagesize=`$here/src/feature -s`
>
> # test case array, test different write/read combinations
> --
> 2.45.2
>
>
next prev parent reply other threads:[~2025-01-28 19:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 7:14 [PATCH] generic/418: use min_dio_alignment Christoph Hellwig
2025-01-28 19:21 ` Darrick J. Wong [this message]
2025-01-29 5:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250128192147.GS3557695@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=hch@lst.de \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.