All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denis@denix.org>
To: "Etheridge, Darren" <detheridge@ti.com>
Cc: rs@ti.com, meta-arago@lists.yoctoproject.org, reatmon@ti.com
Subject: Re: [meta-arago][oe-layersetup][PATCH] configs: scarthgap update meta-browser layer sha
Date: Tue, 28 Jan 2025 15:30:23 -0500	[thread overview]
Message-ID: <20250128203023.GH21836@denix.org> (raw)
In-Reply-To: <681ab15c-d59b-4d9d-9443-ab81dd521090@ti.com>

On Fri, Jan 24, 2025 at 01:58:08PM -0600, Etheridge, Darren wrote:
> On 1/23/2025 3:20 PM, Denys Dmytriyenko wrote:
> >A more generic question:
> >
> >There are now multiple configs with meta-browser and meta-selinux listed:
> >
> >* arago-scarthgap: both meta-browser and meta-selinux are disabled
> >* arago-scarthgap-chromium: meta-browser is enabled, meta-selinux is disabled
> >* arago-scarthgap-selinux: meta-browser is disabled, meta-selinux is enabled
> >
> >Since there are now separate configs, should they be cleaned up and layers
> >that are disabled or unused removed from them? That way when you need to bump
> >say meta-browser, you just need to update one config, not all 3.
> >
> 
> This whole thing was a compromise because we didn't want to take the
> hit of building Chromium for every config.  But we did want to give
> the ability to enable Chromium easily in every config.  So we just
> comment it out and leave it up to the end user to uncomment it if
> they want Chromium to get built and burn several hours.  Maybe there
> is a nicer way to do it, but at the time this is what we came up
> with that worked for everybody involved.

Yes, back in Dunfell days this was exactly the case - there was a single main 
config file with meta-browser being commented out (as it also depended on 
deprecated Python2). Before that I kept it at an old commit that still allowed 
Chromium to be built with gcc and didn't require clang (and very long builds).

Anyway, with Kirkstone and Scarthgap, you now have separate configs for builds 
with meta-browser/Chromium enabled, as well as meta-selinux enabled. My point 
being, since there are separate configus for such builds, why still keep 
commented out references in the main config?

I.e. people can use arago-scarthgap-chromium config directly to get a build 
with Chromium enabled, instead of manually modifying the main arago-scarthgap 
config in order to enable Chromium...


> >Moreover, why only scarthgap is being updated? Are there any changes to the
> >master configs?
> 
> Master points to HEAD of the meta-browser layer,  as such the
> recipes don't make any sense for master, as they really attempt to
> enable GPU support on a specific version of Chromium.   If you build
> master you get whatever the latest Chromium is on the meta-browser
> layer without any of these tweaks applied.

Ah, yeah, missed the fact that master configs also have meta-browser pointing 
to the HEAD. Thanks for clarifying this.

-- 
Denys


  reply	other threads:[~2025-01-28 20:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-23 20:12 [meta-arago][oe-layersetup][PATCH] configs: scarthgap update meta-browser layer sha Darren Etheridge
2025-01-23 21:20 ` Denys Dmytriyenko
2025-01-24 19:58   ` Etheridge, Darren
2025-01-28 20:30     ` Denys Dmytriyenko [this message]
2025-01-28 20:43       ` Ryan Eatmon
2025-01-28 20:48         ` Etheridge, Darren
2025-01-28 20:55         ` Denys Dmytriyenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250128203023.GH21836@denix.org \
    --to=denis@denix.org \
    --cc=detheridge@ti.com \
    --cc=meta-arago@lists.yoctoproject.org \
    --cc=reatmon@ti.com \
    --cc=rs@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.