From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <wagi@kernel.org>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Ming Lei <ming.lei@redhat.com>,
James Smart <james.smart@broadcom.com>,
Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH 1/3] nvme-tcp: rate limit error message in send path
Date: Wed, 29 Jan 2025 07:05:34 +0100 [thread overview]
Message-ID: <20250129060534.GA29266@lst.de> (raw)
In-Reply-To: <20250128-nvme-misc-fixes-v1-1-40c586581171@kernel.org>
On Tue, Jan 28, 2025 at 05:34:46PM +0100, Daniel Wagner wrote:
> If a lot of request are in the queue, this message is spamming the logs,
> thus rate limit it.
Are in the queue when what happens? Not that I'm against this,
but if we have a known condition where this error is printed a lot
we should probably skip it entirely for that?
next prev parent reply other threads:[~2025-01-29 6:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 16:34 [PATCH 0/3] misc nvme related fixes Daniel Wagner
2025-01-28 16:34 ` [PATCH 1/3] nvme-tcp: rate limit error message in send path Daniel Wagner
2025-01-29 6:05 ` Christoph Hellwig [this message]
2025-01-30 15:25 ` Daniel Wagner
2025-01-31 7:29 ` Christoph Hellwig
2025-01-31 8:09 ` Sagi Grimberg
2025-01-31 8:09 ` Sagi Grimberg
2025-01-28 16:34 ` [PATCH 2/3] nvme-fc: use ctrl state getter Daniel Wagner
2025-01-29 6:05 ` Christoph Hellwig
2025-01-29 18:39 ` Keith Busch
2025-01-31 8:09 ` Sagi Grimberg
2025-01-28 16:34 ` [PATCH 3/3] blk-mq: fix wait condition for tagset wait completed check Daniel Wagner
2025-01-29 6:07 ` Christoph Hellwig
2025-01-29 9:54 ` Nilay Shroff
2025-01-31 8:13 ` Sagi Grimberg
2025-01-31 8:46 ` Daniel Wagner
2025-01-31 8:54 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250129060534.GA29266@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=wagi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.