All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Even Xu <even.xu@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
	Jiri Kosina <jikos@kernel.org>,
	Xinpeng Sun <xinpeng.sun@intel.com>,
	Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	Mark Pearson <mpearson-lenovo@squebb.ca>
Subject: drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c:298:38: sparse: sparse: dubious: !x | !y
Date: Wed, 29 Jan 2025 22:02:59 +0800	[thread overview]
Message-ID: <202501292144.eFDq4ovr-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   05dbaf8dd8bf537d4b4eb3115ab42a5fb40ff1f5
commit: a688404b2e20f00cce6d0a2b888ef4ca9154e144 HID: intel-thc-hid: intel-thc: Add THC DMA interfaces
date:   3 weeks ago
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20250129/202501292144.eFDq4ovr-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250129/202501292144.eFDq4ovr-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501292144.eFDq4ovr-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c:298:38: sparse: sparse: dubious: !x | !y
   drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/mm.h, ...):
   include/linux/page-flags.h:237:46: sparse: sparse: self-comparison always evaluates to false
   include/linux/page-flags.h:237:46: sparse: sparse: self-comparison always evaluates to false

vim +298 drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c

   287	
   288	static void release_dma_buffers(struct thc_device *dev,
   289					struct thc_dma_configuration *config)
   290	{
   291		size_t prd_tbls_size = array_size(PRD_TABLE_SIZE, config->prd_tbl_num);
   292		unsigned int i;
   293	
   294		if (!config->is_enabled)
   295			return;
   296	
   297		for (i = 0; i < config->prd_tbl_num; i++) {
 > 298			if (!config->sgls[i] | !config->sgls_nent[i])
   299				continue;
   300	
   301			dma_unmap_sg(dev->dev, config->sgls[i],
   302				     config->sgls_nent[i],
   303				     config->dir);
   304	
   305			sgl_free(config->sgls[i]);
   306			config->sgls[i] = NULL;
   307		}
   308	
   309		memset(config->prd_tbls, 0, prd_tbls_size);
   310	
   311		if (config->prd_tbls) {
   312			dma_free_coherent(dev->dev, prd_tbls_size, config->prd_tbls,
   313					  config->prd_tbls_dma_handle);
   314			config->prd_tbls = NULL;
   315			config->prd_tbls_dma_handle = 0;
   316		}
   317	}
   318	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2025-01-29 14:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29 14:02 kernel test robot [this message]
2025-01-29 22:21 ` drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c:298:38: sparse: sparse: dubious: !x | !y David Laight
2025-02-05  2:56   ` Xu, Even
2025-02-05 21:56     ` David Laight
2025-02-06  2:50       ` Xu, Even
2025-02-06  9:04         ` David Laight
2025-02-07  6:11           ` Xu, Even

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202501292144.eFDq4ovr-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=even.xu@intel.com \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=xinpeng.sun@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.