From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A810E1E98F3; Thu, 30 Jan 2025 14:18:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738246720; cv=none; b=q51uFhzcWZeA3AERuCmFag4+IrA3HQ6Q265ljBLue3EsAPoEB2UHyGgPGI4TC40tJcAtVub/RsjJGU/hoTGG96/+1DhUh+xKpK+sdcPMrMQZ5Vryv8GRqQW6y75i3RvxR21QCTdkUqPmNQH1aeQr06gHs5dciLJcN3Qj5p7TxFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738246720; c=relaxed/simple; bh=R56qUIE5lnvR3SUO2gJGgKlkWdpiBWS0ajMFDs3WfJo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eYz09QB5lmg/h6BUwLSmBVY3CP77ZamtouKeHrYJM0WhOstJnS0b/wSuxs312u4OV2MXCQ+GSI1Z+AwJCpXeiew81c7n1h94jMzc2X/ophSiBxYgop/Z+8c6i+Lipprfxl977yJ2PRzsLfq33W4lQdtsiKvVgGPA18K3X/egvLg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cmwptpcm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cmwptpcm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F805C4CED2; Thu, 30 Jan 2025 14:18:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1738246720; bh=R56qUIE5lnvR3SUO2gJGgKlkWdpiBWS0ajMFDs3WfJo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cmwptpcmakwvoNWKKTNKxF0OsS0+VElZ0F9uiEmxNquTuPDdQi1yYnBDHBvzLO9ng 7yay1dZEXMqYfu3CUsO7IaNFt6oO0SLFvKmN11KyX5YWa6MRIVGrkwp50F/9YmVCqv GCvQTXv2GDIcTeYZeMRLNRzt5qlgcQ4vxRM1uGBc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mario Limonciello , Alvin Lee , Roman Li , Daniel Wheeler , Alex Deucher Subject: [PATCH 5.4 14/91] drm/amd/display: Add check for granularity in dml ceil/floor helpers Date: Thu, 30 Jan 2025 15:00:33 +0100 Message-ID: <20250130140134.236618854@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250130140133.662535583@linuxfoundation.org> References: <20250130140133.662535583@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Roman Li commit 0881fbc4fd62e00a2b8e102725f76d10351b2ea8 upstream. [Why] Wrapper functions for dcn_bw_ceil2() and dcn_bw_floor2() should check for granularity is non zero to avoid assert and divide-by-zero error in dcn_bw_ functions. [How] Add check for granularity 0. Cc: Mario Limonciello Reviewed-by: Alvin Lee Signed-off-by: Roman Li Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher (cherry picked from commit f6e09701c3eb2ccb8cb0518e0b67f1c69742a4ec) Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/amd/display/dc/dml/dml_inline_defs.h | 8 ++++++++ 1 file changed, 8 insertions(+) --- a/drivers/gpu/drm/amd/display/dc/dml/dml_inline_defs.h +++ b/drivers/gpu/drm/amd/display/dc/dml/dml_inline_defs.h @@ -67,11 +67,15 @@ static inline double dml_max5(double a, static inline double dml_ceil(double a, double granularity) { + if (granularity == 0) + return 0; return (double) dcn_bw_ceil2(a, granularity); } static inline double dml_floor(double a, double granularity) { + if (granularity == 0) + return 0; return (double) dcn_bw_floor2(a, granularity); } @@ -97,11 +101,15 @@ static inline double dml_ceil_2(double f static inline double dml_ceil_ex(double x, double granularity) { + if (granularity == 0) + return 0; return (double) dcn_bw_ceil2(x, granularity); } static inline double dml_floor_ex(double x, double granularity) { + if (granularity == 0) + return 0; return (double) dcn_bw_floor2(x, granularity); }