From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5E1E1E522; Thu, 30 Jan 2025 14:26:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738247206; cv=none; b=jsmlZAkB5YfVpYjYx5ZfK0LPPVNlJrQIIiMq6WyFBDqxlY+AXx3pjGD0g+U7LN+TM7WKuelHSWjXtyOCHNiMY1Nxe0ei/lQqOPKv819ga5tSgL6mojF1OSzSbGIBlVynez9RPURJPOaHdoFjTOGhnnUGkQS26AzLsMoLManIet4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738247206; c=relaxed/simple; bh=q5/W/y6jAnQeY5A3Hfc08eY30qUzV6CPS+TGA7WD0d8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lBrB0vEl1ay6x8OJKEHuDYnzR/w5u+8yQAEGo+GsAPzYDUkrqjTle4SW8oxZzWwE1tt5AwXLWZQkdU2AUBf/F1qMs2nN3MrNBlvE1ycG2+QVIT11Fpid7tRLNFppfFR/ly9Bc9BpgaZMlXXM+kbHwpkm2d/z6l8pFZ0tu67zrYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1Cu0To3v; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1Cu0To3v" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CE82C4CED2; Thu, 30 Jan 2025 14:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1738247206; bh=q5/W/y6jAnQeY5A3Hfc08eY30qUzV6CPS+TGA7WD0d8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1Cu0To3vFOjesVvonTvpvwTGYEQWjb7Q9YK4wntMYYJLC4Hqm1dGDWmHfKwxeFovs 6IqqmFBbA5bXhv6qSRrnvTleqynrzT6datGbNCWZ3w8vB1QTlcnSw3JY+tNH84kVYo QKNirx+bhHb2SHiVg+GOVRECybncutsFxs94Ebqo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xiang Zhang , Mike Christie , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.10 118/133] scsi: iscsi: Fix redundant response for ISCSI_UEVENT_GET_HOST_STATS request Date: Thu, 30 Jan 2025 15:01:47 +0100 Message-ID: <20250130140147.282917629@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250130140142.491490528@linuxfoundation.org> References: <20250130140142.491490528@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xiang Zhang [ Upstream commit 63ca02221cc5aa0731fe2b0cc28158aaa4b84982 ] The ISCSI_UEVENT_GET_HOST_STATS request is already handled in iscsi_get_host_stats(). This fix ensures that redundant responses are skipped in iscsi_if_rx(). - On success: send reply and stats from iscsi_get_host_stats() within if_recv_msg(). - On error: fall through. Signed-off-by: Xiang Zhang Link: https://lore.kernel.org/r/20250107022432.65390-1-hawkxiang.cpp@gmail.com Reviewed-by: Mike Christie Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/scsi_transport_iscsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index 074cbd64aa253..c636a6d3bdcc1 100644 --- a/drivers/scsi/scsi_transport_iscsi.c +++ b/drivers/scsi/scsi_transport_iscsi.c @@ -4076,7 +4076,7 @@ iscsi_if_rx(struct sk_buff *skb) } do { /* - * special case for GET_STATS: + * special case for GET_STATS, GET_CHAP and GET_HOST_STATS: * on success - sending reply and stats from * inside of if_recv_msg(), * on error - fall through. @@ -4085,6 +4085,8 @@ iscsi_if_rx(struct sk_buff *skb) break; if (ev->type == ISCSI_UEVENT_GET_CHAP && !err) break; + if (ev->type == ISCSI_UEVENT_GET_HOST_STATS && !err) + break; err = iscsi_if_send_reply(portid, nlh->nlmsg_type, ev, sizeof(*ev)); if (err == -EAGAIN && --retries < 0) { -- 2.39.5