From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 066B71E522; Thu, 30 Jan 2025 14:27:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738247230; cv=none; b=jyKi15JMxNs7RnnIqwzptjtH2DTH135PUN4dojw6If7dDm4nkOlXQPAdmCRFsWO0Q9uTqLCIC5xDddwV3O0cVrXB/5zJsrrkjLpqTgA447Vl9dzokR3coLwqh9qyKQelKzsrhVUb1RPxVbsWMoT+0vyUrkvPxWYw5hREMi/ubVs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738247230; c=relaxed/simple; bh=ny3zJyJtz3K1An5Vhdn/riUCyc+rPffE6pDi9xGHf28=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Z/XoNOrK2/ixuX0GJ8dtv86mcMjdJh4BJOFoKKjs7vvwtcVtqysc4GkccA3OdeqL8zLKMB1lP9XaHzhdoQC0LAYTUg8/V9S3JQSY+V+eZzOgL9wTyUhVvbi3Ih/vVmQfSYAEFAn4NyEXjHMdmWaS60fBfb3Vob+JcILmFP4UeWo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=I366FbOu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="I366FbOu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81CA7C4CED2; Thu, 30 Jan 2025 14:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1738247229; bh=ny3zJyJtz3K1An5Vhdn/riUCyc+rPffE6pDi9xGHf28=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I366FbOu98XC29WsaSiu05OVEIQtD/e5Jc9tNrrmGbH4FZSpF0LOl2VcvOy5Lmi/H hSszW84GZubrSV/D2XFNJwo2Lsue2A9JGNO956NsAXEOkKvNC+nfE7cii4oIqTbjMH v0ev2TYw9nBW6i2jmOU4qLACv0BiGcmgrSn+J75M= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mostafa Saleh , Eric Auger , Alex Williamson Subject: [PATCH 5.10 125/133] vfio/platform: check the bounds of read/write syscalls Date: Thu, 30 Jan 2025 15:01:54 +0100 Message-ID: <20250130140147.561289478@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250130140142.491490528@linuxfoundation.org> References: <20250130140142.491490528@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Alex Williamson commit ce9ff21ea89d191e477a02ad7eabf4f996b80a69 upstream. count and offset are passed from user space and not checked, only offset is capped to 40 bits, which can be used to read/write out of bounds of the device. Fixes: 6e3f26456009 (“vfio/platform: read and write support for the device fd”) Cc: stable@vger.kernel.org Reported-by: Mostafa Saleh Reviewed-by: Eric Auger Reviewed-by: Mostafa Saleh Tested-by: Mostafa Saleh Signed-off-by: Alex Williamson Signed-off-by: Greg Kroah-Hartman --- drivers/vfio/platform/vfio_platform_common.c | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/drivers/vfio/platform/vfio_platform_common.c +++ b/drivers/vfio/platform/vfio_platform_common.c @@ -405,6 +405,11 @@ static ssize_t vfio_platform_read_mmio(s { unsigned int done = 0; + if (off >= reg->size) + return -EINVAL; + + count = min_t(size_t, count, reg->size - off); + if (!reg->ioaddr) { reg->ioaddr = ioremap(reg->addr, reg->size); @@ -482,6 +487,11 @@ static ssize_t vfio_platform_write_mmio( { unsigned int done = 0; + if (off >= reg->size) + return -EINVAL; + + count = min_t(size_t, count, reg->size - off); + if (!reg->ioaddr) { reg->ioaddr = ioremap(reg->addr, reg->size);