[djiang:cxl/fwctl 17/25] drivers/cxl/core/features.c:202: undefined reference to `fwctl_unregister'

[kernel test robot <lkp@intel.com>]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/djiang/linux.git cxl/fwctl
head:   a94a98755ebe43e2cf8fa8b60eb78c64f9d9bdce
commit: 50bb7ff9edf14d384d8cd902ac40e41abee77651 [17/25] cxl: Add FWCTL support to the CXL memdev driver
config: i386-randconfig-054-20250130 (https://download.01.org/0day-ci/archive/20250130/202501301920.Seg3Ke0X-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250130/202501301920.Seg3Ke0X-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501301920.Seg3Ke0X-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/cxl/core/features.o: in function `remove_cxlfs':
>> drivers/cxl/core/features.c:202: undefined reference to `fwctl_unregister'
   ld: drivers/cxl/core/features.o: in function `devm_cxl_add_features':
>> drivers/cxl/core/features.c:222: undefined reference to `_fwctl_alloc_device'
>> ld: drivers/cxl/core/features.c:233: undefined reference to `fwctl_register'
   ld: drivers/cxl/core/features.o: in function `remove_cxlfs':
>> drivers/cxl/core/features.c:202: undefined reference to `fwctl_unregister'


vim +202 drivers/cxl/core/features.c

   194	
   195	static void remove_cxlfs(void *_md)
   196	{
   197		struct cxl_memdev *cxlmd = _md;
   198		struct cxl_features_state *cxlfs = cxlmd->cxlfs;
   199		struct fwctl_device *fwctl = &cxlfs->fwctl;
   200	
   201		cxlmd->cxlfs = NULL;
 > 202		fwctl_unregister(fwctl);
   203		fwctl_put(fwctl);
   204	}
   205	
   206	DEFINE_FREE(free_cxlfs, struct cxl_features_state *, if (_T) fwctl_put(&_T->fwctl))
   207	
   208	/**
   209	 * devm_cxl_add_features() - Allocate and initalize features context
   210	 * @cxlmd: CXL memory device
   211	 * @ops: FWCTL ops
   212	 *
   213	 * Return 0 on success or -errno on failure.
   214	 */
   215	int devm_cxl_add_features(struct cxl_memdev *cxlmd,
   216				  const struct fwctl_ops *ops)
   217	{
   218		struct device *dev = &cxlmd->dev;
   219		int rc;
   220	
   221		struct cxl_features_state *cxlfs __free(free_cxlfs) =
 > 222			fwctl_alloc_device(dev, ops, struct cxl_features_state, fwctl);
   223		if (!cxlfs)
   224			return -ENOMEM;
   225	
   226		enumerate_feature_cmds(cxlmd, cxlfs);
   227		rc = get_supported_features(cxlmd, cxlfs);
   228		if (rc) {
   229			dev_dbg(dev, "Retrieving features failed.\n");
   230			return 0;
   231		}
   232	
 > 233		rc = fwctl_register(&cxlfs->fwctl);
   234		if (rc)
   235			return rc;
   236	
   237		cxlfs->cxlmd = cxlmd;
   238		cxlmd->cxlfs = no_free_ptr(cxlfs);
   239	
   240		return devm_add_action_or_reset(dev, remove_cxlfs, cxlmd);
   241	}
   242	EXPORT_SYMBOL_NS_GPL(devm_cxl_add_features, "CXL");
   243	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki