From: Kees Cook <kees@kernel.org>
To: Joel Granados <joel.granados@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Anna Schumaker <anna.schumaker@oracle.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Baoquan He <bhe@redhat.com>, Bill O'Donnell <bodonnel@redhat.com>,
Corey Minyard <cminyard@mvista.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Jani Nikula <jani.nikula@intel.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Song Liu <song@kernel.org>, Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Wei Liu <wei.liu@kernel.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: Re: [GIT PULL] sysctl constification changes for v6.14-rc1
Date: Fri, 31 Jan 2025 12:03:39 -0800 [thread overview]
Message-ID: <202501311203.D6FDB314@keescook> (raw)
In-Reply-To: <iay2bmkotede6c5xkxnfvxwgxg2drmcc6az3eeiijkkz3ftie7@co4cir66ksz2>
On Fri, Jan 31, 2025 at 02:57:40PM +0100, Joel Granados wrote:
> From 431abf6c9c11a8b7321842ed0747b3200d43ef34 Mon Sep 17 00:00:00 2001
> From: Joel Granados <joel.granados@kernel.org>
> Date: Fri, 31 Jan 2025 14:10:57 +0100
> Subject: [PATCH] csky: Remove the size from alignment_tbl declaration
>
> Having to synchronize the number of ctl_table array elements with the
> size in the declaration can lead to discrepancies between the two
> values. Since commit d7a76ec87195 ("sysctl: Remove check for sentinel
> element in ctl_table arrays"), the calculation of the ctl_table array
> size is done solely by the ARRAY_SIZE macro removing the need for the
> size in the declaration.
>
> Remove the size for the aligment_tbl declaration and const qualify the
> array for good measure.
>
> Signed-off-by: Joel Granados <joel.granados@kernel.org>
FWIW, this looks correct to me.
Reviewed-by: Kees Cook <kees@kernel.org>
--
Kees Cook
next prev parent reply other threads:[~2025-01-31 20:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-29 8:14 [GIT PULL] sysctl constification changes for v6.14-rc1 Joel Granados
2025-01-29 18:48 ` Linus Torvalds
2025-01-31 13:57 ` Joel Granados
2025-01-31 20:03 ` Kees Cook [this message]
2025-02-05 9:03 ` Joel Granados
2025-01-29 20:00 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202501311203.D6FDB314@keescook \
--to=kees@kernel.org \
--cc=anna.schumaker@oracle.com \
--cc=ashutosh.dixit@intel.com \
--cc=bhe@redhat.com \
--cc=bodonnel@redhat.com \
--cc=cminyard@mvista.com \
--cc=djwong@kernel.org \
--cc=jani.nikula@intel.com \
--cc=joel.granados@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rostedt@goodmis.org \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.