From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9AD4C0218F for ; Fri, 31 Jan 2025 15:15:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7363C42538; Fri, 31 Jan 2025 15:15:41 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Q_VFlSgvgGE1; Fri, 31 Jan 2025 15:15:32 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1037042587 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1738336532; bh=bBgxakqGTODAZQrWbpRz8eWj42IF2NxsAmvMx6vxCso=; h=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RZafBtSBCUfXMKTp+8ieTA+ZnbhICMHAfoqcBFd7n98ugA/XTVBcuLLiUul98hn8K XrOh+z9HOpF6yUORe9YcbRKnw/zn0eavxX80E3eGRsc6+H3FB69MK429a7VuIvHRVU p/PcdJGUGQM9lA+/IDOyVCFMFyjEbLq72PPWTUg2ugwshYgA/5FsgYkY1L6GPDGJrq l5uuUcBf0rBRyOHZXNDyVrtq+tjO5cJbNRFgJ6OzxTnBcRIv/KZC2aWVBjoesjEoR2 KoAmUs7T6MlHbXKhLtfEjlV0QGqr7eJiM1+I19+t2M2W1excNdULEz2dmOJSzxyOkz uaRBKoW8r3XNg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 1037042587; Fri, 31 Jan 2025 15:15:32 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists1.osuosl.org (Postfix) with ESMTP id 310BC16E for ; Fri, 31 Jan 2025 15:15:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1566F60EBE for ; Fri, 31 Jan 2025 15:15:29 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id GpewW_TloDBV for ; Fri, 31 Jan 2025 15:15:28 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:45d1:ec00::3; helo=nyc.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 66E4F60F2B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 66E4F60F2B Received: from nyc.source.kernel.org (nyc.source.kernel.org [IPv6:2604:1380:45d1:ec00::3]) by smtp3.osuosl.org (Postfix) with ESMTPS id 66E4F60F2B for ; Fri, 31 Jan 2025 15:15:28 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 45BEEA41653; Fri, 31 Jan 2025 15:13:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A954C4CED1; Fri, 31 Jan 2025 15:15:24 +0000 (UTC) Date: Fri, 31 Jan 2025 15:15:22 +0000 From: Simon Horman To: Piotr Kwapulinski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, dan.carpenter@linaro.org, yuehaibing@huawei.com, maciej.fijalkowski@intel.com, przemyslaw.kitszel@intel.com Message-ID: <20250131151522.GB34138@kernel.org> References: <20250131121450.11645-1-piotr.kwapulinski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250131121450.11645-1-piotr.kwapulinski@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738336526; bh=3VVkjJDKB0JX6i7wVotCXHhAkh/YA5ViSbV7lBGvic4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jYPv8BBIphfS7XFB5tNzRhc2Hnng2AoZGZVTUnxOkeQEhWguUllW6p0GD7BSgDWm0 ytaP3rKiccOnCSMWpsfZCI92o458gnM2CMUxqP7mnkxbvJzMef2mX0QQkxtUc6/G2/ 6nvPmjD/796KIUkzO93YE8G3INRv4zAGixzfH6F3bYExE3MC0/guLLCRLGrQVMAmxF 6CkcU8/RzZITMC7atE5MF8Po4z3DKypWk9TqA9k6FbP7H6fyT744imfHI7gPbzw5fB aUs2RTwzcORaocFMJYGhfnZx5qKXFOZG0AcwsBsYjyGkmGAX2/R7jDEyIkN/JHlslh 7jiyVewEmwbnw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=jYPv8BBI Subject: Re: [Intel-wired-lan] [PATCH iwl-next v4] ixgbe: Fix possible skb NULL pointer dereference X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Jan 31, 2025 at 01:14:50PM +0100, Piotr Kwapulinski wrote: > The commit c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in > ixgbe_run_xdp()") stopped utilizing the ERR-like macros for xdp status > encoding. Propagate this logic to the ixgbe_put_rx_buffer(). > > The commit also relaxed the skb NULL pointer check - caught by Smatch. > Restore this check. > > Fixes: c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()") > Reported-by: Dan Carpenter > Acked-by: Maciej Fijalkowski > Signed-off-by: Piotr Kwapulinski Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15E8C20318 for ; Fri, 31 Jan 2025 15:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738336527; cv=none; b=bwd12tsoCPxIaRxYmvfWqvr6f7nbuS4RtjrnkV9uLSmcPXHkXXt7sS1/ZCcDKGsbLEkY+pJlUTPQWL4gMrmVZ00tAhipts6FOSu6Q6vqO4ZCclgMFArhjOW2uC/Mow+iI7g5pzM1ody1Y1MT9fZ4gEY45eEf7tE2HfTcAgh2Ut8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738336527; c=relaxed/simple; bh=3VVkjJDKB0JX6i7wVotCXHhAkh/YA5ViSbV7lBGvic4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CnlWTDW+VDBcAIQZJMMVA0ZyEMd0MXckuUiNbdzY2Cpk+pYIckHB61wbKVAeCYGMFiGuno1VFsaqNrT8CPGiAEbaYCO4WfZpNe/WjJJ8ojNJaMCOgYdoPIbMXZaWeC5MXoo3RZRagolzKb4SM5ZE5yQVOj4jfKH0+jQTIENmAqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jYPv8BBI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jYPv8BBI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A954C4CED1; Fri, 31 Jan 2025 15:15:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738336526; bh=3VVkjJDKB0JX6i7wVotCXHhAkh/YA5ViSbV7lBGvic4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jYPv8BBIphfS7XFB5tNzRhc2Hnng2AoZGZVTUnxOkeQEhWguUllW6p0GD7BSgDWm0 ytaP3rKiccOnCSMWpsfZCI92o458gnM2CMUxqP7mnkxbvJzMef2mX0QQkxtUc6/G2/ 6nvPmjD/796KIUkzO93YE8G3INRv4zAGixzfH6F3bYExE3MC0/guLLCRLGrQVMAmxF 6CkcU8/RzZITMC7atE5MF8Po4z3DKypWk9TqA9k6FbP7H6fyT744imfHI7gPbzw5fB aUs2RTwzcORaocFMJYGhfnZx5qKXFOZG0AcwsBsYjyGkmGAX2/R7jDEyIkN/JHlslh 7jiyVewEmwbnw== Date: Fri, 31 Jan 2025 15:15:22 +0000 From: Simon Horman To: Piotr Kwapulinski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, dan.carpenter@linaro.org, yuehaibing@huawei.com, maciej.fijalkowski@intel.com, przemyslaw.kitszel@intel.com Subject: Re: [PATCH iwl-next v4] ixgbe: Fix possible skb NULL pointer dereference Message-ID: <20250131151522.GB34138@kernel.org> References: <20250131121450.11645-1-piotr.kwapulinski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250131121450.11645-1-piotr.kwapulinski@intel.com> On Fri, Jan 31, 2025 at 01:14:50PM +0100, Piotr Kwapulinski wrote: > The commit c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in > ixgbe_run_xdp()") stopped utilizing the ERR-like macros for xdp status > encoding. Propagate this logic to the ixgbe_put_rx_buffer(). > > The commit also relaxed the skb NULL pointer check - caught by Smatch. > Restore this check. > > Fixes: c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()") > Reported-by: Dan Carpenter > Acked-by: Maciej Fijalkowski > Signed-off-by: Piotr Kwapulinski Reviewed-by: Simon Horman