From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C74C1BD9FA for ; Fri, 31 Jan 2025 11:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738323114; cv=none; b=oBb6pNIvBzUrARVAiXeoXBTSDqDT4Jseno0zsG694Ad3PJdx6eELQSrYb8iVgaD1heiNBRqb2SJjL81c8mhGr2dB/89xzVRAiyqdzX5uXhOtsRtXit39jTJqZnUYhvN9gmhXgbN3DFEha/1HBuSqBljimdkOWbkICBl4HMCjC/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738323114; c=relaxed/simple; bh=2fnjjGHhXad8BkluByyPQEb4KLoDbLXJYl3tnARdpDY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cdfzDQYHioTDeVuOwWTRmNcRhCYRFbnIGQo2fuwg3YM59fbQ3MLFfCRil3GNvCBG8N/r87aAyIsP/NvkErGDZ/uaAT2ZxRgQAi2K5OBeI/CPbL87E9aoE+497dhghwbYp6sdTFjkfiKwXe06bgrPKSaaCiRMXjnT06X/GvqnKcM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=es6U7cfU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="es6U7cfU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C3BDC4CEE2; Fri, 31 Jan 2025 11:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1738323114; bh=2fnjjGHhXad8BkluByyPQEb4KLoDbLXJYl3tnARdpDY=; h=From:To:Cc:Subject:Date:Reply-to:From; b=es6U7cfU+12Y+BF0SXXWr+u2CJsMOc/wo6CrzKD4xA2WQ1jLucSwMMwMmwo0xoOYM qVCKxPs6w2+7j+q+uq91tGycvgDiW3fJ8uVVMzR4jpO2/c+ipGxB9yZSJXkdLpXpov t9eJimyqHpEBFHjMWXpX1J5cSjkeyiP5mjzV+YPY= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2025-21670: vsock/bpf: return early if transport is not assigned Date: Fri, 31 Jan 2025 12:31:02 +0100 Message-ID: <2025013159-CVE-2025-21670-5d52@gregkh> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=2985; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=2fnjjGHhXad8BkluByyPQEb4KLoDbLXJYl3tnARdpDY=; b=owGbwMvMwCRo6H6F97bub03G02pJDOlzthT773c2OP2xVsQoZvuf6e5zpsybqKPxr63A3Wijy Nm8OX+3d8SyMAgyMciKKbJ82cZzdH/FIUUvQ9vTMHNYmUCGMHBxCsBECrwZFuzYvVXta43j87vr vpRGsrFXvXFf+YphFtMWFYHnhTN+GDzS+1zhe8uSu4ivAQA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: vsock/bpf: return early if transport is not assigned Some of the core functions can only be called if the transport has been assigned. As Michal reported, a socket might have the transport at NULL, for example after a failed connect(), causing the following trace: BUG: kernel NULL pointer dereference, address: 00000000000000a0 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 12faf8067 P4D 12faf8067 PUD 113670067 PMD 0 Oops: Oops: 0000 [#1] PREEMPT SMP NOPTI CPU: 15 UID: 0 PID: 1198 Comm: a.out Not tainted 6.13.0-rc2+ RIP: 0010:vsock_connectible_has_data+0x1f/0x40 Call Trace: vsock_bpf_recvmsg+0xca/0x5e0 sock_recvmsg+0xb9/0xc0 __sys_recvfrom+0xb3/0x130 __x64_sys_recvfrom+0x20/0x30 do_syscall_64+0x93/0x180 entry_SYSCALL_64_after_hwframe+0x76/0x7e So we need to check the `vsk->transport` in vsock_bpf_recvmsg(), especially for connected sockets (stream/seqpacket) as we already do in __vsock_connectible_recvmsg(). The Linux kernel CVE team has assigned CVE-2025-21670 to this issue. Affected and fixed versions =========================== Issue introduced in 6.4 with commit 634f1a7110b439c65fd8a809171c1d2d28bcea6f and fixed in 6.6.74 with commit 58e586c30d0b6f5dc0174a41026f2b0a48c9aab6 Issue introduced in 6.4 with commit 634f1a7110b439c65fd8a809171c1d2d28bcea6f and fixed in 6.12.11 with commit 6771e1279dadf1d92a72e1465134257d9e6f2459 Issue introduced in 6.4 with commit 634f1a7110b439c65fd8a809171c1d2d28bcea6f and fixed in 6.13 with commit f6abafcd32f9cfc4b1a2f820ecea70773e26d423 Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2025-21670 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: net/vmw_vsock/vsock_bpf.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/58e586c30d0b6f5dc0174a41026f2b0a48c9aab6 https://git.kernel.org/stable/c/6771e1279dadf1d92a72e1465134257d9e6f2459 https://git.kernel.org/stable/c/f6abafcd32f9cfc4b1a2f820ecea70773e26d423