From: Denis Kirjanov <kirjanov@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: maddy@linux.ibm.com, mpe@ellerman.id.au,
benh@kernel.crashing.org, Denis Kirjanov <kirjanov@gmail.com>
Subject: [PATCH] powerpc/powermac: fix a loop in core99_usb_enable
Date: Sun, 2 Feb 2025 07:46:40 -0500 [thread overview]
Message-ID: <20250202124641.2722-1-kirjanov@gmail.com> (raw)
Looks like we have a typo in the do-while loop
while checking the loop condition. Fix it with the boolean OR
Signed-off-by: Denis Kirjanov <kirjanov@gmail.com>
---
arch/powerpc/platforms/powermac/feature.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
index d3bcfe590384..9d929fbfc46b 100644
--- a/arch/powerpc/platforms/powermac/feature.c
+++ b/arch/powerpc/platforms/powermac/feature.c
@@ -1174,7 +1174,7 @@ core99_usb_enable(struct device_node *node, long param, long value)
mdelay(1);
status0 = UN_IN(UNI_N_CLOCK_STOP_STATUS0);
status1 = UN_IN(UNI_N_CLOCK_STOP_STATUS1);
- } while ((status0 & test0) | (status1 & test1));
+ } while ((status0 & test0) || (status1 & test1));
LOCK(flags);
}
} else {
--
2.47.2
next reply other threads:[~2025-02-02 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-02 12:46 Denis Kirjanov [this message]
2025-02-02 17:05 ` [PATCH] powerpc/powermac: fix a loop in core99_usb_enable Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250202124641.2722-1-kirjanov@gmail.com \
--to=kirjanov@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.