All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Herbolt <lukas@herbolt.com>
To: cem@kernel.org, djwong@kernel.org
Cc: linux-xfs@vger.kernel.org, Lukas Herbolt <lukas@herbolt.com>
Subject: [PATCH 0/1] RFE: Do not check NEEDSREPAIR if ro,norecovery mount.
Date: Mon,  3 Feb 2025 09:55:12 +0100	[thread overview]
Message-ID: <20250203085513.79335-1-lukas@herbolt.com> (raw)

Hi,
I disccussed this shortly with Eric Sandeen. I have came across 
corruption where xfs_repair fails and the only way how to get at
least some of the data is to use manually clear out the NEEDSREPAIR
flag. I do not think there is needs of checking if we are about
to mount the FS with norecovery,ro.

Lukas Herbolt (1):
  xfs: do not check NEEDSREPAIR if ro,norecovery mount.

 fs/xfs/xfs_super.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

-- 
2.48.1


             reply	other threads:[~2025-02-03  9:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-03  8:55 Lukas Herbolt [this message]
2025-02-03  8:55 ` [PATCH 1/1] xfs: do not check NEEDSREPAIR if ro,norecovery mount Lukas Herbolt
2025-02-03 22:26   ` Darrick J. Wong
2025-02-04 17:55     ` Eric Sandeen
2025-02-04 19:59       ` Darrick J. Wong
2025-02-04 20:18   ` Dave Chinner
2025-02-04 20:37   ` Eric Sandeen
2025-02-11  8:44   ` Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250203085513.79335-1-lukas@herbolt.com \
    --to=lukas@herbolt.com \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.