From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E385DC139 for ; Mon, 3 Feb 2025 16:24:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738599900; cv=none; b=ZziTnz4SGsjtkH04YMCkIE9+IPQTtj0StkPC8tMQ3Q2H4OB3IwBzZsAfROGO/5ZYkl5WKNq1Q4HjJPAjExzeFvX/l2ssGCEZrNaogFdFbOFZd3XFW53YDW618JvVHS+CUK7I6xBPCQIpdjF1LWLcBlo0p9y5lPIt6KbA2hglyTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738599900; c=relaxed/simple; bh=i81LAFq6Pgd51jrkZnwSNmAsa4pQbq+8Gg0E7E3go2U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BKLvr9dkoI0wDuuJ97eTYisB0WLZR1cWiY1+i3QvTfIAHFNzoWh5hOcB0HAIo5Xs6lq7xurypBXQV5JdLRKdHVUN0o9M4ZkJc/rAn+mRx3qREm52nDKtgyFYo0ZeWpu3mmGdIbXn/MFgrM0ZjdYL1oOO8bGzVb98vnl2RcLfkv8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A3klhSfA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A3klhSfA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D50E8C4CED2; Mon, 3 Feb 2025 16:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738599899; bh=i81LAFq6Pgd51jrkZnwSNmAsa4pQbq+8Gg0E7E3go2U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A3klhSfAzqmYvx5vIiF68v4/lXC/xESjxJYrJS/tuXeYUeziAeOZx74XBJANteJSQ lQs9lybmBNFv73yj0ZBIKgrB0pcGMN1Vla8mRfphojbx4YEshSAXTgxcBrjU2sXzLc p5BMn5AvqFt9tQfC/jVOs8tzUIMQm/kxGs8vAGyiLd1N3lAGwB78tr+VsYh7VWOfGk PDNdSt9YoOMiGwsqwzRelazb4ivujzDHb4bqdoUzq+0UimJj+g4clAbLq+7tyNZRle 0MdkfrK91uPZ4JmT2cqaQ3AJ56MyOYeYJeUJ1kOJgIJtRuwWNrgDZ9nr6dJ0JoSC2F RiNXBAZQ2gDOw== From: Sasha Levin To: stable@vger.kernel.org Cc: Shubham Pushpkar , Sasha Levin Subject: Re: [Fix CVE-2024-50217 in v6.6.y] [PATCH] btrfs: fix use-after-free of block device file in __btrfs_free_extra_devids() Date: Mon, 3 Feb 2025 11:24:57 -0500 Message-Id: <20250203104236-79c0781f6bba7d6e@stable.kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250203123719.52811-1-spushpka@cisco.com> References: Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [ Sasha's backport helper bot ] Hi, Found matching upstream commit: aec8e6bf839101784f3ef037dcdb9432c3f32343 WARNING: Author mismatch between patch and found commit: Backport author: Shubham Pushpkar Commit author: Zhihao Cheng Status in newer kernel trees: 6.13.y | Present (exact SHA1) 6.12.y | Present (exact SHA1) 6.6.y | Not found Note: The patch differs from the upstream commit: --- 1: aec8e6bf83910 ! 1: afbc8c0c36536 btrfs: fix use-after-free of block device file in __btrfs_free_extra_devids() @@ Metadata ## Commit message ## btrfs: fix use-after-free of block device file in __btrfs_free_extra_devids() + commit aec8e6bf839101784f3ef037dcdb9432c3f32343 ("btrfs: + fix use-after-free of block device file in __btrfs_free_extra_devids()") + Mounting btrfs from two images (which have the same one fsid and two different dev_uuids) in certain executing order may trigger an UAF for variable 'device->bdev_file' in __btrfs_free_extra_devids(). And @@ Commit message Signed-off-by: Zhihao Cheng Reviewed-by: David Sterba Signed-off-by: David Sterba + (cherry picked from commit aec8e6bf839101784f3ef037dcdb9432c3f32343) + Signed-off-by: Shubham Pushpkar ## fs/btrfs/volumes.c ## @@ fs/btrfs/volumes.c: static void btrfs_close_one_device(struct btrfs_device *device) --- Results of testing on various branches: | Branch | Patch Apply | Build Test | |---------------------------|-------------|------------| | stable/linux-6.6.y | Success | Failed | Build Errors: Build error for stable/linux-6.6.y: lib/test_dhry.o: warning: objtool: dhry() falls through to next function dhry_run_set.cold() fs/btrfs/volumes.c: In function 'btrfs_close_one_device': fs/btrfs/volumes.c:1179:23: error: 'struct btrfs_device' has no member named 'bdev_file' 1179 | device->bdev_file = NULL; | ^~ make[4]: *** [scripts/Makefile.build:243: fs/btrfs/volumes.o] Error 1 make[4]: Target 'fs/btrfs/' not remade because of errors. make[3]: *** [scripts/Makefile.build:480: fs/btrfs] Error 2 make[3]: Target 'fs/' not remade because of errors. make[2]: *** [scripts/Makefile.build:480: fs] Error 2 make[2]: Target './' not remade because of errors. make[1]: *** [/home/sasha/build/linus-next/Makefile:1921: .] Error 2 make[1]: Target '__all' not remade because of errors. make: *** [Makefile:234: __sub-make] Error 2 make: Target '__all' not remade because of errors.