From: Tomer Maimon <tmaimon77@gmail.com>
To: <openbmc@lists.ozlabs.org>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Charles Boyer <Charles.Boyer@fii-usa.com>,
Tali Perry <tali.perry1@gmail.com>,
Tyrone Ting <kfting@nuvoton.com>,
Vivekanand Veeracholan <vveerach@google.com>,
Joel Stanley <joel@jms.id.au>
Subject: [PATCH linux dev-6.6 v1 8/8] i2c: npcm: Enable slave in eob interrupt
Date: Mon, 3 Feb 2025 18:14:50 +0200 [thread overview]
Message-ID: <20250203161450.265480-9-tmaimon77@gmail.com> (raw)
In-Reply-To: <20250203161450.265480-1-tmaimon77@gmail.com>
From: Charles Boyer <Charles.Boyer@fii-usa.com>
Nuvoton slave enable was in user space API call master_xfer, so it is
subject to delays from the OS scheduler. If the BMC is not enabled for
slave mode in time for master to send response, then it will NAK the
address match. Then the PLDM request timeout occurs.
If the slave enable is moved to the EOB interrupt service routine, then
the BMC can be ready in slave mode by the time it needs to receive a
response.
Signed-off-by: Charles Boyer <Charles.Boyer@fii-usa.com>
Signed-off-by: Vivekanand Veeracholan <vveerach@google.com>
Signed-off-by: Tyrone Ting <kfting@nuvoton.com>
Reviewed-by: Tali Perry <tali.perry1@gmail.com>
Link: https://lore.kernel.org/r/20241219090859.18722-5-kfting@nuvoton.com
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
---
drivers/i2c/busses/i2c-npcm7xx.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c
index 81f6dc95aced..706a9d64e481 100644
--- a/drivers/i2c/busses/i2c-npcm7xx.c
+++ b/drivers/i2c/busses/i2c-npcm7xx.c
@@ -1926,6 +1926,12 @@ static int npcm_i2c_int_master_handler(struct npcm_i2c *bus)
(FIELD_GET(NPCM_I2CCST3_EO_BUSY,
ioread8(bus->reg + NPCM_I2CCST3)))) {
npcm_i2c_irq_handle_eob(bus);
+#if IS_ENABLED(CONFIG_I2C_SLAVE)
+ /* reenable slave if it was enabled */
+ if (bus->slave)
+ iowrite8(bus->slave->addr | NPCM_I2CADDR_SAEN,
+ bus->reg + NPCM_I2CADDR1);
+#endif
return 0;
}
--
2.34.1
prev parent reply other threads:[~2025-02-03 17:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 16:14 [PATCH linux dev-6.6 v1 0/8] i2c: npcm7xx: Various upstream modification Tomer Maimon
2025-02-03 16:14 ` [PATCH linux dev-6.6 v1 1/8] i2c: Remove redundant comparison in npcm_i2c_reg_slave Tomer Maimon
2025-02-03 16:14 ` [PATCH linux dev-6.6 v1 2/8] i2c: npcm: restore slave addresses array length Tomer Maimon
2025-02-03 16:14 ` [PATCH linux dev-6.6 v1 3/8] i2c: npcm: correct the read/write operation procedure Tomer Maimon
2025-02-03 16:14 ` [PATCH linux dev-6.6 v1 4/8] i2c: npcm: use a software flag to indicate a BER condition Tomer Maimon
2025-02-03 16:14 ` [PATCH linux dev-6.6 v1 5/8] i2c: npcm: Modify timeout evaluation mechanism Tomer Maimon
2025-02-03 16:14 ` [PATCH linux dev-6.6 v1 6/8] i2c: npcm: Assign client address earlier for `i2c_recover_bus()` Tomer Maimon
2025-02-03 16:14 ` [PATCH linux dev-6.6 v1 7/8] i2c: npcm: use i2c frequency table Tomer Maimon
2025-02-03 16:14 ` Tomer Maimon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203161450.265480-9-tmaimon77@gmail.com \
--to=tmaimon77@gmail.com \
--cc=Charles.Boyer@fii-usa.com \
--cc=andi.shyti@kernel.org \
--cc=joel@jms.id.au \
--cc=kfting@nuvoton.com \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=vveerach@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.