From: Oleg Nesterov <oleg@redhat.com>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: ebiederm@xmission.com, brauner@kernel.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/6] exit: postpone tty_kref_put() until after tasklist_lock is dropped
Date: Mon, 3 Feb 2025 19:06:24 +0100 [thread overview]
Message-ID: <20250203180623.GC1003@redhat.com> (raw)
In-Reply-To: <20250201163106.28912-4-mjguzik@gmail.com>
On 02/01, Mateusz Guzik wrote:
>
> Instead of smuggling the tty pointer directly, use a struct so that more
> things can be added later.
I am not sure this particular change worth the effort, but I won't argue.
I'd like to know what Eric thinks.
OTOH, if we do this, then perhaps we can do more "call tty_kref_put()
lockless" changes later. And perhaps even add the new
void tty_kref_put_sync(struct tty_struct *tty)
{
if (tty)
kref_put(&tty->kref, release_one_tty);
}
helper. With this change release_task() doesn't need to abuse
schedule_work(), and this helper can have more users.
Nevermind, this is almost off-topic.
Oleg.
next prev parent reply other threads:[~2025-02-03 18:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 16:31 [PATCH v3 0/6] reduce tasklist_lock hold time on exit and do some Mateusz Guzik
2025-02-01 16:31 ` [PATCH v3 1/6] exit: perform add_device_randomness() without tasklist_lock Mateusz Guzik
2025-02-03 17:51 ` Oleg Nesterov
2025-02-03 17:55 ` Mateusz Guzik
2025-02-01 16:31 ` [PATCH v3 2/6] exit: hoist get_pid() in release_task() outside of tasklist_lock Mateusz Guzik
2025-02-03 19:27 ` Liam R. Howlett
2025-02-03 19:35 ` Mateusz Guzik
2025-02-03 20:13 ` Liam R. Howlett
2025-02-03 20:22 ` Mateusz Guzik
2025-02-03 20:28 ` Liam R. Howlett
2025-02-04 1:51 ` Andrew Morton
2025-02-01 16:31 ` [PATCH v3 3/6] exit: postpone tty_kref_put() until after tasklist_lock is dropped Mateusz Guzik
2025-02-03 18:06 ` Oleg Nesterov [this message]
2025-02-03 19:33 ` Mateusz Guzik
2025-02-04 11:22 ` Oleg Nesterov
2025-02-04 12:12 ` Mateusz Guzik
2025-02-01 16:31 ` [PATCH v3 4/6] pid: sprinkle tasklist_lock asserts Mateusz Guzik
2025-02-01 16:31 ` [PATCH v3 5/6] pid: perform free_pid() calls outside of tasklist_lock Mateusz Guzik
2025-02-03 18:49 ` Oleg Nesterov
2025-02-03 19:31 ` Mateusz Guzik
2025-02-03 20:02 ` Oleg Nesterov
2025-02-01 16:31 ` [PATCH v3 6/6] pid: drop irq disablement around pidmap_lock Mateusz Guzik
2025-02-01 17:42 ` Oleg Nesterov
2025-02-01 17:45 ` Oleg Nesterov
2025-02-01 18:19 ` David Laight
2025-02-01 18:42 ` Mateusz Guzik
2025-02-01 21:51 ` David Laight
2025-02-01 22:00 ` Matthew Wilcox
2025-02-02 13:55 ` David Laight
2025-02-02 19:34 ` Mateusz Guzik
2025-02-02 20:44 ` David Laight
2025-02-02 22:06 ` Matthew Wilcox
2025-02-03 17:47 ` [PATCH v3 0/6] reduce tasklist_lock hold time on exit and do some Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203180623.GC1003@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mjguzik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.